Two different fixers should not handle same imports

[mvorisek]

Feature request

It seems at least new import is now handled by:

• https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.46.0/doc/rules/import/fully_qualified_strict_types.rst and import_symbols option
• and https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.46.0/doc/rules/import/global_namespace_import.rst import_classes option

I would expect this to be deduplicated, global_namespace_import should be probably deprecated and removed later.

This is maintanance issue only, fully_qualified_strict_types has higher priority, thus all work is done before global_namespace_import is run and I do not observe any related functional bug.

[Wirone]

Importing symbols from global namespace is explicitly skipped in fully_qualified_strict_types, there is even test case for that. At this point these fixers are not colliding, but I agree these should be merged into one, under a more appropriate name 🙂.

[mvorisek]

Let's add these two options to fully_qualified_strict_types:

• "import_global_symbols" (non-namespaced symbols, ie. Exception but not \A\Exception)
• "import_relative_symbols" (like A\B with A import) - UPDATE: implemented in feat: add fully_qualified_strict_types fixer import_relative_symbols option #7721

[Wirone]

I was thinking rather about the ability to define import_symbols both as bool (fully enabled / disabled) or an array with more specific options, where top-level true would act as true for all of the options. This way we could introduce fine-tuned options for importing classes/function/constants just like global_namespace_import has.