Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BinaryOperatorSpacesFixer - better handling of Arrow Functions #6334

Closed
wants to merge 1 commit into from
Closed

BinaryOperatorSpacesFixer - better handling of Arrow Functions #6334

wants to merge 1 commit into from

Conversation

SpacePossum
Copy link
Contributor

@SpacePossum SpacePossum commented Mar 9, 2022 •
edited

closes #6223
closes #6220
closes #5667
depends on #6333

This was referenced Mar 9, 2022
Closed
Closed
@coveralls
Copy link

coveralls commented Mar 9, 2022 •
edited

Coverage Status

Coverage increased (+0.007%) to 93.128% when pulling 7c5aad5 on SpacePossum:BinaryOperatorSpaces_fn_align into aa805a8 on FriendsOfPHP:master.

@SpacePossum SpacePossum mentioned this pull request Mar 9, 2022
Closed
@SpacePossum SpacePossum changed the title Binary operator spaces fn align BinaryOperatorSpacesFixer - better handling of Arrow Functions Mar 10, 2022
@VincentLanglet VincentLanglet mentioned this pull request Mar 11, 2022
Merged
@keradus
Copy link
Member

keradus commented Mar 15, 2022

depends on #6333

6333 got merged

@SpacePossum
Copy link
Contributor Author

thanks, rebased

@SpacePossum
Copy link
Contributor Author

Can someone merge this? what is the wait?

@SpacePossum SpacePossum closed this May 9, 2022
@SpacePossum SpacePossum deleted the BinaryOperatorSpaces_fn_align branch May 9, 2022 16:45
@keradus
Copy link
Member

keradus commented May 9, 2022

i was having very limited availability due to personal life topics.
can you reopen @SpacePossum ? I would love to merge it.

let's aim to have a call to see why you cannot merge anymore and let's have it fixed.

@keradus keradus added the RTM Ready To Merge label May 9, 2022
@kubawerlos kubawerlos removed the RTM Ready To Merge label Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
5 participants
@SpacePossum @coveralls @keradus @GrahamCampbell @kubawerlos