binary_operator_spaces doesn't work in function

[volovodenko]

Bug report

• PHP version: 8.0.2
  • PHP CS Fixer version: 2.18.6
  • the command used to run PHP CS Fixer (run with -vvv)
  • the configuration (file) you used

'binary_operator_spaces' => [
'operators' => [
'+=' => 'align_single_space_minimal',
'=' => 'align_single_space_minimal',
'=>' => 'align_single_space_minimal'
],
],

Code snippet that reproduces the problem

  <?php
  \DB::transaction(function () use ($entity) {
            $goalFile = new GoalFile();
            $goalFile->goal_id = $entity->goalId()->value();
            $goalFile->author_id = $entity->authorId()->value();
            $goalFile->original_name = $entity->name();
            $goalFile->description = $entity->description();

            $file = new File();
            $file->storage = $entity->attributes()->storage();
            $file->directory = $entity->attributes()->directory();
            $file->file_name = $entity->attributes()->fileName();
            $file->mime_type = $entity->attributes()->mimeType();
            $file->size = $entity->attributes()->size();
            $file->save();

            $goalFile->file()->associate($file);
            $goalFile->save();
        });

Also another type of issue with arrow functions

  <?php
  private function keys(): array
    {
        return [
            'email'                                       => fn ($value)                                       => mb_strtolower($value),
            'fio'                                         => fn ($value)                                         => $this->userNameParser($value),
            'inn'                                         => fn ($value)                                         => mb_strtoupper($value),
            'rol'                                         => fn ($value)                                         => mb_strtolower($value),
            'tabelnyi_nomer'                              => fn ($value)                              => mb_strtoupper($value),
            'nazvanie_podrazdeleniya'                     => fn ($value)                     => $this->divisionNameParser($value),
            'kod_podrazdeleniya'                          => fn ($value)                          => mb_strtoupper($value),
            'yavlyaetsya_li_rukovoditelem_podrazdeleniya' => fn ($value) => mb_strtolower($value),
            'roditelskoe_podrazdelenie'                   => fn ($value)                   => $this->divisionNameParser($value),
            'kod_roditelskogo_podrazdeleniya'             => fn ($value)             => mb_strtoupper($value),
            'nazvanie_dolznosti'                          => fn ($value)                          => $this->positionNameParser($value),
            'kod_dolznosti'                               => fn ($value)                               => mb_strtoupper($value),
        ];
    }

[GrahamCampbell]

I don't see how the second example is a bug? The => in the fn () => code is not a binary operator - it's special syntax for that kind of function, so is out of scope of this fixer.

[volovodenko]

But why fixer aligns it randomly? If its out of him scope.

[GrahamCampbell]

Oh, you didn't post the before file? I assumed the report was that it wasn't changing the arrows?

[volovodenko]

[johanvanhelden]

I stumbled upon the same issue. Hoping it was fixed in V3, but unfortunately it is not.

Rule:

'binary_operator_spaces' => [
    'default'   => 'single_space',
    'operators' => [
        '=>' => 'align_single_space_minimal',
    ],
],

Before:

public function share(Request $request): array
{
    return array_merge(parent::share($request), [
        'flashNotifications' => fn () => Session::get('flash_notification'),
        'currentUser' => fn () => $this->getCurrentUser($request->user()),
        'menuItems' => fn () => $this->getMenuItems($request->user()),
    ]);
}

After:

public function share(Request $request): array
{
    return array_merge(parent::share($request), [
        'flashNotifications' => fn () => Session::get('flash_notification'),
        'currentUser'        => fn ()        => $this->getCurrentUser($request->user()),
        'menuItems'          => fn ()          => $this->getMenuItems($request->user()),
    ]);
}

Expectation:

public function share(Request $request): array
{
    return array_merge(parent::share($request), [
        'flashNotifications' => fn () => Session::get('flash_notification'),
        'currentUser'        => fn () => $this->getCurrentUser($request->user()),
        'menuItems'          => fn () => $this->getMenuItems($request->user()),
    ]);
}

[VincentLanglet]

I think it will be fixed by #6112

[SpacePossum]

thanks for reporting, needed additional fixing, please see #6334

[SamuelWei]

I have a similar issue, not sure if it fits here or should be a new issue.

During upgrading of PHP-CS-Fixer (see littleredbutton/bigbluebutton-api-php#130) I changed the config from:

'binary_operator_spaces' => [
    'align_double_arrow' => true,
    'align_equals'       => true,
]

to:

'binary_operator_spaces' => ['operators' => ['=' => 'align', '=>' => 'align']]

As a result the expression inside the function argument is changed.
Can this be prevented by setting another option, is this a bug or intended?

Before

$hooksCreateParameters->setMeetingId($meetingId = $this->faker->uuid);
$hooksCreateParameters->setGetRaw($getRaw = $this->faker->boolean);

After

$hooksCreateParameters->setMeetingId($meetingId = $this->faker->uuid);
$hooksCreateParameters->setGetRaw($getRaw       = $this->faker->boolean);

Expected

$hooksCreateParameters->setMeetingId($meetingId = $this->faker->uuid);
$hooksCreateParameters->setGetRaw($getRaw = $this->faker->boolean);