Calculate code coverage on PHP 8 #5689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keradus
reviewed
May 5, 2021
.github/workflows/ci.yml
Outdated
| @@ -37,9 +37,6 @@ jobs: | |||
|
|
|||
| - operating-system: 'ubuntu-20.04' | |||
| php-version: '7.4' | |||
| job-description: 'with calculating code coverage' | |||
| calculate-code-coverage: 'yes' | |||
| phpunit-flags: '--testsuite coverage --exclude-group covers-nothing --coverage-clover build/logs/clover.xml' | |||
|
|
|||
| - operating-system: 'ubuntu-20.04' | |||
| php-version: '7.4' | |||
There was a problem hiding this comment.
Suggested change
| php-version: '7.4' | |
| php-version: '8.0' |
There was a problem hiding this comment.
same few lines later for job-description: 'with migration rules'
There was a problem hiding this comment.
SRP, let's do code coverage PHP version update here and handle others in separate PR (as some syntax is broken with migration in PHP 8 and tests are failing).
There was a problem hiding this comment.
then drop the duplicated 7.4 job, we don't need 2 of them anymore
keradus
reviewed
May 6, 2021
| @@ -53,7 +47,9 @@ jobs: | |||
|
|
|||
| - operating-system: 'ubuntu-20.04' | |||
| php-version: '8.0' | |||
| composer-flags: '--ignore-platform-req=php' # as this is a version not yet officially supported by PHP CS Fixer | |||
There was a problem hiding this comment.
i wonder, maybe we should add 8.1 ?
There was a problem hiding this comment.
sounds like a good idea... for separate PR ;)
keradus
approved these changes
May 6, 2021
GrahamCampbell
approved these changes
May 12, 2021
|
Thank you @kubawerlos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's almost a half a year since the release, we can use PHP 8 to calculate code coverage e.g. to avoid situation like in #5685 where it shows that coverage dropped.