Skip to content

Commit

Permalink
minor #5689 Calculate code coverage on PHP 8 (kubawerlos)
Browse files Browse the repository at this point in the history
This PR was squashed before being merged into the 2.19 branch.

Discussion
----------

Calculate code coverage on PHP 8

It's almost a half a year since the release, we can use PHP 8 to calculate code coverage e.g. to avoid situation like in #5685 where it shows that coverage dropped.

Commits
-------

acc1806 Calculate code coverage on PHP 8
  • Loading branch information
keradus committed May 13, 2021
2 parents f2f6e3b + acc1806 commit 98ad482
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions .github/workflows/ci.yml
Expand Up @@ -35,12 +35,6 @@ jobs:
PHP_CS_FIXER_TEST_USE_LEGACY_TOKENIZER: 1
SYMFONY_DEPRECATIONS_HELPER: 'disabled'

- operating-system: 'ubuntu-20.04'
php-version: '7.4'
job-description: 'with calculating code coverage'
calculate-code-coverage: 'yes'
phpunit-flags: '--testsuite coverage --exclude-group covers-nothing --coverage-clover build/logs/clover.xml'

- operating-system: 'ubuntu-20.04'
php-version: '7.4'
job-description: 'with deployment'
Expand All @@ -53,7 +47,9 @@ jobs:

- operating-system: 'ubuntu-20.04'
php-version: '8.0'
composer-flags: '--ignore-platform-req=php' # as this is a version not yet officially supported by PHP CS Fixer
job-description: 'with calculating code coverage'
calculate-code-coverage: 'yes'
phpunit-flags: '--testsuite coverage --exclude-group covers-nothing --coverage-clover build/logs/clover.xml'

- operating-system: 'windows-latest'
php-version: '7.4'
Expand Down

0 comments on commit 98ad482

Please sign in to comment.