Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid old config filename usage #5609

Merged
merged 1 commit into from Apr 13, 2021
Merged

Forbid old config filename usage #5609

merged 1 commit into from Apr 13, 2021

Conversation

keradus
Copy link
Member

@keradus keradus commented Apr 7, 2021 •
edited

@keradus keradus added this to the 3.0.0 milestone Apr 7, 2021
@keradus keradus mentioned this pull request Apr 7, 2021
Merged
@coveralls
Copy link

coveralls commented Apr 7, 2021 •
edited

Coverage Status

Coverage increased (+0.005%) to 91.962% when pulling 7ba957d on keradus:restrict_config_filename_usage into 3ac438a on FriendsOfPHP:3.0.

mvorisek
mvorisek reviewed Apr 8, 2021
View reviewed changes
UPGRADE-v3.md Outdated
Comment on lines 9 to 13
| 2.x | 3.0 | Description |
| ---------------- | ------------------------ | -------------------------------------- |
| `.php_cs` | `.php-cs-fixer.php` | Configuration file (local) |
| `.php_cs.dist` | `.php-cs-fixer.dist.php` | Configuration file (to be distributed) |
| `.php_cs.cache` | `.php-cs-fixer.cache` | Cache file |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 2.x | 3.0 | Description |
| ---------------- | ------------------------ | -------------------------------------- |
| `.php_cs` | `.php-cs-fixer.php` | Configuration file (local) |
| `.php_cs.dist` | `.php-cs-fixer.dist.php` | Configuration file (to be distributed) |
| `.php_cs.cache` | `.php-cs-fixer.cache` | Cache file |
| 2.x | 3.0 | Description |
| ---------------- | ------------------------- | -------------------------------------- |
| `.php_cs.dist` | `.php-cs-fixer.php` | Configuration file (to be distributed) |
| `.php_cs` | `.php-cs-fixer.local.php` | Configuration file (local) |
| `.php_cs.cache` | `.php-cs-fixer.cache` | Cache file |

@keradus keradus force-pushed the restrict_config_filename_usage branch from 15c0dd7 to bfc96da Compare April 12, 2021 20:45
keradus added a commit that referenced this pull request Apr 13, 2021
@keradus
minor #5607 DX: new config filename (keradus)
d627acb 
This PR was squashed before being merged into the 2.19-dev branch.

Discussion
----------

DX: new config filename

old files are still allowed. will be disallowed with upgrade msg in #5609

Commits
-------

c704d13 DX: new config filename
@keradus keradus force-pushed the restrict_config_filename_usage branch from bfc96da to ff0cf69 Compare April 13, 2021 13:42
@keradus keradus changed the title Restrict config filename usage Forbid old config filename usage Apr 13, 2021
@keradus keradus marked this pull request as ready for review April 13, 2021 13:53
@keradus keradus force-pushed the restrict_config_filename_usage branch from 0cef634 to 7ba957d Compare April 13, 2021 15:18
@keradus keradus merged commit 814aac8 into PHP-CS-Fixer:3.0 Apr 13, 2021
@keradus keradus deleted the restrict_config_filename_usage branch April 18, 2021 19:38
@yguedidi yguedidi mentioned this pull request May 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvorisek mvorisek mvorisek left review comments

@localheinz localheinz localheinz approved these changes

@kubawerlos kubawerlos kubawerlos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@keradus @coveralls @localheinz @mvorisek @kubawerlos