Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config files with .php extension #246

Closed
yguedidi opened this issue May 17, 2022 · 1 comment · Fixed by #247
Closed

Support config files with .php extension #246

yguedidi opened this issue May 17, 2022 · 1 comment · Fixed by #247

Comments

@yguedidi
Copy link
Contributor

In addition to the already supported .twig_cs and .twig_cs.dist files, I suggest to add the support for .twig_cs.php and .twig_cs.dist.php
Inspired from PHP-CS-Fixer, they already did that in PHP-CS-Fixer/PHP-CS-Fixer#5607, they also have removed the support of old names in PHP-CS-Fixer/PHP-CS-Fixer#5609

Benefits of this move are:

  • IDE will automatically detect the file as being a PHP file
  • the config file can be targeted in a generic way with *.php like other PHP files to be included in other CS tools like PHP-CS-Fixer, PHP_CodeSniffer, etc, no need to maintain it as a particular case

I can try to come with a PR if the idea is accepted

@localheinz
Copy link
Collaborator

@yguedidi

Sounds like a good improvement to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants