Add NoUnneededImportAliasFixer

README.rst

@@ -1139,6 +1139,10 @@ Choose from the list of available rules:
 
   There MUST be no trailing spaces inside comment or PHPDoc.
 
+* **no_unneeded_alias**
+
+  Remove unneeded alias in ``use`` clauses.
+
 * **no_unneeded_control_parentheses** [@Symfony, @PhpCsFixer]
 
   Removes unneeded parentheses around control statements.

src/Fixer/Import/NoUnneededAliasFixer.php

@@ -0,0 +1,93 @@
+<?php
+
+/*
+ * This file is part of PHP CS Fixer.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *     Dariusz Rumiński <dariusz.ruminski@gmail.com>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace PhpCsFixer\Fixer\Import;
+
+use PhpCsFixer\AbstractFixer;
+use PhpCsFixer\FixerDefinition\CodeSample;
+use PhpCsFixer\FixerDefinition\FixerDefinition;
+use PhpCsFixer\Tokenizer\Analyzer\Analysis\NamespaceUseAnalysis;
+use PhpCsFixer\Tokenizer\Analyzer\NamespaceUsesAnalyzer;
+use PhpCsFixer\Tokenizer\Tokens;
+
+final class NoUnneededAliasFixer extends AbstractFixer
+{
+    /**
+     * {@inheritdoc}
+     */
+    public function getDefinition()
+    {
+        return new FixerDefinition(
+            'Remove unneeded alias in `use` clauses.',
+            [new CodeSample("<?php\nnamespace Foo;\nuse Bar\\Baz as Baz;\n")]
+        );
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function getPriority()
+    {
+        // should be run after the SingleImportPerStatementFixer (for fix separated use statements as well) and NoUnusedImportsFixer (just for save performance) and NoLeadingImportSlashFixer
+        return -25;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function isCandidate(Tokens $tokens)
+    {
+        return $tokens->isTokenKindFound(T_USE);
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function applyFix(\SplFileInfo $file, Tokens $tokens)
+    {
+        $useDeclarations = (new NamespaceUsesAnalyzer())->getDeclarationsFromTokens($tokens);
+
+        if (0 === \count($useDeclarations)) {
+            return;
+        }
+
+        foreach ($useDeclarations as $declaration) {
+            if (!$declaration->isAliased()) {
+                continue;
+            }
+            $shortNameStartPos = strrpos($declaration->getFullName(), '\\');
+            $shortName = false === $shortNameStartPos ? $declaration->getFullName() : substr($declaration->getFullName(), $shortNameStartPos + 1);
+
+            if ($declaration->getShortName() !== $shortName) {
+                continue;
+            }
+
+            $this->removeAlias($tokens, $declaration);
+        }
+    }
+
+    private function removeAlias(Tokens $tokens, NamespaceUseAnalysis $declaration)
+    {
+        // no fix if any comment found.
+        $commentIndex = $tokens->getNextTokenOfKind($declaration->getStartIndex(), [[T_COMMENT], [T_DOC_COMMENT]]);
+        if (null !== $commentIndex && $commentIndex <= $declaration->getEndIndex()) {
+            return;
+        }
+
+        $asIndex = $tokens->getNextTokenOfKind($declaration->getStartIndex(), [[T_AS]]);
+        if (null === $asIndex || $asIndex > $declaration->getEndIndex()) {
+            return;
+        }
+
+        $tokens->clearRange($tokens->getPrevMeaningfulToken($asIndex) + 1, $declaration->getEndIndex() - 1);
+    }
+}

tests/Fixer/Import/NoUnneededAliasFixerTest.php

@@ -0,0 +1,92 @@
+<?php
+
+/*
+ * This file is part of PHP CS Fixer.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *     Dariusz Rumiński <dariusz.ruminski@gmail.com>
+ *
+ * This source file is subject to the MIT license that is bundled
+ * with this source code in the file LICENSE.
+ */
+
+namespace PhpCsFixer\Tests\Fixer\Import;
+
+use PhpCsFixer\Tests\Test\AbstractFixerTestCase;
+
+/**
+ * @internal
+ *
+ * @covers \PhpCsFixer\Fixer\Import\NoUnneededAliasFixer
+ */
+final class NoUnneededAliasFixerTest extends AbstractFixerTestCase
+{
+    /**
+     * @param string      $expected
+     * @param null|string $input
+     *
+     * @dataProvider provideFixCases
+     */
+    public function testFix($expected, $input = null)
+    {
+        $this->doTest($expected, $input);
+    }
+
+    public function provideFixCases()
+    {
+        return [
+            'simple' => [
+                <<<'EOF'
+<?php
+
+use Foo\Bar\FooBar;
+use const some\a\ConstA;
+use function some\a\fn_b;
+EOF
+                ,
+                <<<'EOF'
+<?php
+
+use Foo\Bar\FooBar as FooBar;
+use const some\a\ConstA as ConstA;
+use function some\a\fn_b as fn_b;
+EOF
+            ],
+            'comments' => [
+                <<<'EOF'
+<?php
+
+use Foo\Bar\FooBar as /* idem */FooBar;
+use /* - */const some\a\ConstA as ConstA;
+use function some\a\fn_b /* - */as fn_b;
+EOF
+            ],
+            'case sensitive' => [
+                <<<'EOF'
+<?php
+
+use Foo\Bar\FooBar as fooBar;
+use const some\a\ConstA as Consta;
+use function some\a\fn_b as fn_B;
+EOF
+            ],
+            'extra spaces' => [
+                <<<'EOF'
+<?php
+
+use Foo\Bar\FooBar;
+use const some\a\ConstA;
+use function some\a\fn_b;
+EOF
+                ,
+                <<<'EOF'
+<?php
+
+use Foo\Bar\FooBar  as FooBar  ;
+use const some\a\ConstA as   ConstA   ;
+use function some\a\fn_b   as   fn_b ;
+EOF
+            ],
+        ];
+    }
+}