Add NoUnneededImportAliasFixer #4498
Conversation
| */ | ||
| public function getPriority() | ||
| { | ||
| // should be run after the SingleImportPerStatementFixer (for fix separated use statements as well) and NoUnusedImportsFixer (just for save performance) and NoLeadingImportSlashFixer |
There was a problem hiding this comment.
IMO this new fixer should be able to deal with grouped imports in case single_import_per_statement is not enabled. This would remove the priority issue. Same with no_leading_import_slash.
There was a problem hiding this comment.
Sadly NamespaceUsesAnalyzer skips group and multiple use
There was a problem hiding this comment.
Add support for multiple use (not group) with an extra argument to avoid side effect
|
Look good to me now but I don't understand red build |
|
Hi @JakeFr ! I did not had a chance yet to look into your PR, but I take my chances to understand why Travis is red - I can now confirm that it's not related to changes on your PR, but to Travis unattended update of some libraries. I tried to fix it here: #4516 |
| public function getDefinition() | ||
| { | ||
| return new FixerDefinition( | ||
| 'Remove unneeded alias in `use` clauses.', |
There was a problem hiding this comment.
reading this sentence, i don't know what unneeded means.
is baz as baz only case? then, audience of this rule is very limited
There was a problem hiding this comment.
it's unneeded when the alias is equal to the last part of the fqcn
same with function and const imports
I found some import in big legacy project
not found in recent projects with modern IDE
|
|
||
| // Multiple imports on one line: | ||
| // use My\Full\Classname as Another, My\Full\NSname; | ||
| // TODO: How to support these: |
There was a problem hiding this comment.
i guess this is not yet resolved?
There was a problem hiding this comment.
not resolved, NamespaceUseAnalysis wont fit for group import
start and end tokens do not apply as the use is not in one piece
|
LGTM now |
| $this->doTest($expected, $input); | ||
| } | ||
|
|
||
| public function provideFixCases() |
There was a problem hiding this comment.
Please add test cases with grouped imports.
| private function removeAlias(Tokens $tokens, NamespaceUseAnalysis $declaration) | ||
| { | ||
| $asIndex = $tokens->getNextTokenOfKind($declaration->getStartIndex(), [[T_AS]]); | ||
| if (null === $asIndex || $asIndex > $declaration->getEndIndex()) { |
There was a problem hiding this comment.
This method is only called if the import uses an alias so this should never happen.
|
Is this PR still relevant? It addresses a feature I'd very much like to see in a future release. If there is some work remaining, I'd be happy to contribute |
|
Hi, And as it was mentioned the scope is very limited, this poc was used in a big legacy project with php 5 and "old generation" IDE. |
Hi
First fixer, try to implement #4492