New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AlignMultilineCommentFixer - ArrayIndentationFixer - Priority #3885
AlignMultilineCommentFixer - ArrayIndentationFixer - Priority #3885
Conversation
It should run after ArrayIndentationFixer.
a690efc
to
bd51b51
Compare
Note: my commit can be squashed when merging :) |
I'm not sure I agree with the added commit, it serves no use other than taking away the focus of why it was added in the first place. edit: also, the comment is now no longer valid, since the aligning is even more off haha |
I added invalid indent on other lines to make
What do you mean? |
The comment reads |
The comment is still aligned with values in the expected result, and never was in the input. Adding invalid indent didn't change that. |
Sorry but no, look again: it's aligned with the keys in the expected result. It was aligned with the values in my original input. |
Oh I see what you meant now. But I still prefer the current input: it explicitly shows that indentation of the array changes, while aligning the comment with values (instead of keys) has few value for this test IMO. If we keep current input, the comment should be updated indeed. |
The indentation of the array already changed, the comment gets moved. Or at least the first line of the comment. That is being done by |
cd444f6
to
bd51b51
Compare
Ok, I removed my commit. |
do we've the same (hidden) priority issue with |
|
Thanks @dmvdbrugge. |
It should run after ArrayIndentationFixer.
This fixes #3860