bug #3885 AlignMultilineCommentFixer - ArrayIndentationFixer - Priori…

…ty (dmvdbrugge)

This PR was merged into the 2.12 branch.

Discussion
----------

AlignMultilineCommentFixer - ArrayIndentationFixer - Priority

It should run after ArrayIndentationFixer.

This fixes #3860

Commits
-------

bd51b51 Add priority to AlignMultilineCommentFixer

src/Fixer/Phpdoc/AlignMultilineCommentFixer.php

@@ -83,6 +83,15 @@ public function getDefinition()
         );
     }
 
+    /**
+     * {@inheritdoc}
+     */
+    public function getPriority()
+    {
+        // Should run after ArrayIndentationFixer
+        return -40;
+    }
+
     /**
      * {@inheritdoc}
      */

tests/AutoReview/FixerFactoryTest.php

@@ -60,6 +60,7 @@ public function provideFixersPriorityCases()
 
         return [
             [$fixers['array_indentation'], $fixers['binary_operator_spaces']],
+            [$fixers['array_indentation'], $fixers['align_multiline_comment']],
             [$fixers['array_syntax'], $fixers['binary_operator_spaces']],
             [$fixers['array_syntax'], $fixers['ternary_operator_spaces']],
             [$fixers['backtick_to_shell_exec'], $fixers['escape_implicit_backslashes']],

tests/Fixtures/Integration/priority/array_indentation,align_multiline_comment.test

@@ -0,0 +1,25 @@
+--TEST--
+Integration of fixers: array_indentation,align_multiline_comment.
+--RULESET--
+{"array_indentation": true, "align_multiline_comment": {"comment_type": "all_multiline"}}
+--EXPECT--
+<?php
+
+$array = [
+    /*
+     * Aligned with the values
+     */
+    'this' => 'is a bug',
+    'but'  => 'this is too',
+];
+
+--INPUT--
+<?php
+
+$array = [
+              /*
+               * Aligned with the values
+               */
+    'this' => 'is a bug',
+    'but'  => 'this is too',
+];