Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ERC1967Utils pragma to 0.8.21 and set Slither CI version to 0.10.1 #5005

Merged

Conversation

dimitriospapathanasiou
Copy link
Contributor

@dimitriospapathanasiou dimitriospapathanasiou commented Apr 8, 2024

Fixes #4995

I noticed the related issue about the pragma that is used. After minor local tests, I verified that the increase to 0.8.21 works well.

Same as #4999 but with the proper files added. Excuse my previous PR, I am a first time contributor. Sorry for any inconvenience.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Apr 8, 2024

⚠️ No Changeset found

Latest commit: 9d1860b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Amxx
Amxx previously approved these changes Apr 8, 2024
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dimitriospapathanasiou

We don't need a changeset for that.

We need @ernestognw 's 2nd approval and we are good.

@ernestognw
Copy link
Member

Looks good to me as well, I just added a note to the changelog referring to the breaking changes arising from this.

ernestognw
ernestognw previously approved these changes Apr 8, 2024
@ernestognw
Copy link
Member

CI is broken due to Slither 0.10.2. The rule breaking is pragma but I'm struggling to see why it's failing now.

Let's not unblock this and set the Slither version to 0.10.1 for now.

@ernestognw ernestognw changed the title Add correct pragma Bump ERC1967Utils pragma to 0.8.21 and set Slither CI version to 0.10.1 Apr 8, 2024
@ernestognw ernestognw merged commit 5212e8e into OpenZeppelin:master Apr 8, 2024
19 checks passed
@ernestognw ernestognw mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect pragma
3 participants