Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v5 docs #5012

Draft
wants to merge 1 commit into
base: release-v5.0
Choose a base branch
from

Conversation

ernestognw
Copy link
Member

@ernestognw ernestognw commented Apr 10, 2024

Updates the documentation site with #5004 changes

Co-authored-by: ernestognw <ernestognw@gmail.com>
Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: f386348

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw ernestognw requested a review from Amxx April 10, 2024 17:18
@ernestognw ernestognw changed the title Update release v5 docs Update v5 docs Apr 10, 2024
@Amxx
Copy link
Collaborator

Amxx commented Apr 10, 2024

can we fix the slither thing @ernestognw

@ernestognw
Copy link
Member Author

Yeah, looking into it.

It's the same as in this comment. We can fix the slither version for now, but I'm thinking how to do it in a way that doesn't make conflicts when merging back the release branch to master.

@ernestognw
Copy link
Member Author

Seems like this is it: crytic/slither#2415

I'm marking this PR as draft instead, I think it's better to wait for a fix than change it in this branch, given there are pragma-related changes in #5005 we can't cherry pick it too.

@ernestognw ernestognw marked this pull request as draft April 10, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants