Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ECDSA signature malleability #3610

Merged
merged 4 commits into from Aug 10, 2022
Merged

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Aug 10, 2022

Fixes a kind of signature malleability that is present in the ECDSA.recover and tryRecover variants that take a bytes signature argument, which can be both 65 bytes long and the compact 64 bytes encoded version.

@frangio frangio requested a review from Amxx August 10, 2022 18:21
Copy link
Collaborator

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good !

@frangio frangio merged commit d693d89 into OpenZeppelin:master Aug 10, 2022
@frangio frangio deleted the fix-malleability branch August 10, 2022 18:40
frangio added a commit that referenced this pull request Aug 10, 2022
@y0wl
Copy link

y0wl commented Aug 11, 2022

For reference, this pull request is motivated by this security advisory - GHSA-4h98-2769-gh6h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants