Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDSA.sol version used is subject to signature malleability. #17

Closed
code423n4 opened this issue Apr 28, 2023 · 2 comments
Closed

ECDSA.sol version used is subject to signature malleability. #17

code423n4 opened this issue Apr 28, 2023 · 2 comments
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-363 edited-by-warden unsatisfactory does not satisfy C4 submission criteria; not eligible for awards

Comments

@code423n4
Copy link
Contributor

code423n4 commented Apr 28, 2023 •
edited

Lines of code

https://github.com/code-423n4/2023-04-eigenlayer/blob/5e4872358cd2bda1936c29f460ece2308af4def6/src/contracts/core/StrategyManager.sol#L293
https://github.com/code-423n4/2023-04-eigenlayer/blob/5e4872358cd2bda1936c29f460ece2308af4def6/src/contracts/core/DelegationManager.sol#L94

Vulnerability details

Impact

Depositing and Delegating via a signature is subject to signature malleablility due to use of an old version of ECDSA.sol library that supports compact signatures. This could lead to malleable signatures being used to deposit funds into strategies that a user does not want to deposit into, as well as the possibility of an malleable signature being used to delegate shares to an unintended operator.

Proof of Concept

Pull request for open zeppelin library detailing vuln and fix.
OpenZeppelin/openzeppelin-contracts#3610

Tools Used

Recommended Mitigation Steps

update to latest ECDSA.sol version.

Assessed type

Library
@code423n4 code423n4 added 2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working labels Apr 28, 2023
code423n4 added a commit that referenced this issue Apr 28, 2023
@code423n4
Jigsaw issue #17
9e5ac7a
@c4-pre-sort
Copy link

0xSorryNotSorry marked the issue as duplicate of #363

@c4-judge c4-judge added the unsatisfactory does not satisfy C4 submission criteria; not eligible for awards label Jun 8, 2023
@c4-judge
Copy link
Contributor

c4-judge commented Jun 8, 2023

GalloDaSballo marked the issue as unsatisfactory:
Invalid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Assets not at direct risk, but function/availability of the protocol could be impacted or leak value bug Something isn't working duplicate-363 edited-by-warden unsatisfactory does not satisfy C4 submission criteria; not eligible for awards
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@code423n4 @c4-judge @c4-pre-sort