Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnumerableMap.AddressToUintMap #3073

Closed
wants to merge 3 commits into from

Conversation

Tynukua
Copy link

@Tynukua Tynukua commented Jan 3, 2022

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx
Copy link
Collaborator

Amxx commented Jan 3, 2022

Hello @Tynukua

Do you have a specific need for this flavor of EnumerableMap? Are you planning to use it for storing balances?

I think it would be a great addition to this library, but I would go one step further and addressToBytes32 and bytes32ToAddress functions to cleanup all the casting. They could be file-level function, or we could add them to a library (either safecast or something new)

@Amxx Amxx requested review from frangio and Amxx January 3, 2022 17:08
@fdietze
Copy link

fdietze commented Jan 16, 2022

I am also interested in this addition.

My use case would indeed be to store balances.

@gaspardip
Copy link
Contributor

Same use case here, surprised it has't been added yet.

@Amxx
Copy link
Collaborator

Amxx commented Jan 28, 2022

I don't think there is any reason not to include that.

The next steps would be to add testing and a Changelog entry.

@gaspardip
Copy link
Contributor

gaspardip commented Jan 28, 2022

I don't think there is any reason not to include that.

The next steps would be to add testing and a Changelog entry.

I can do that, should I continue this in another PR?

@gaspardip gaspardip mentioned this pull request Jan 30, 2022
3 tasks
@frangio
Copy link
Contributor

frangio commented Jan 31, 2022

Closing in favor of #3150.

@frangio frangio closed this Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants