Add AddressToUintMap #3150
Merged
Add AddressToUintMap #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
frangio
changed the title
frangio
reviewed
Feb 1, 2022
Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Amxx
reviewed
Feb 1, 2022
| "overrides": [ | ||
| { | ||
| "files": "*.sol", | ||
| "options": { | ||
| "singleQuote": false, |
There was a problem hiding this comment.
Do we need these changes to .prettierrc ? Can you explain what they do exactly ?
There was a problem hiding this comment.
The lint config doesn't match the prettier config for what I've noticed using the vscode prettier extension (although running the package.json lint scripts would give the same result)
|
For the |
Amxx
approved these changes
Feb 1, 2022
brandonlehmann
added a commit
to brandonlehmann/openzeppelin-contracts
that referenced
this pull request
Feb 13, 2022
* add AddressToUintMap * Update contracts/utils/structs/EnumerableMap.sol Co-authored-by: Francisco Giordano <frangio.1@gmail.com> * address comments * lint code * merge mocks into a single file * add PR link to changelog entry Co-authored-by: Francisco Giordano <frangio.1@gmail.com> Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work of #3073, this PR adds the new
AddressToUintMapmap type, which is very useful for storing balances.I've added tests and a changelog entry.
PR Checklist