grel: Prepare tests for modularization #6571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetneb
commented
Apr 28, 2024
| public void tearDown() { | ||
| bindings = null; | ||
| } | ||
|
|
There was a problem hiding this comment.
I have also used this opportunity to clean up unnecessary set up functions which are already included in the base class.
tfmorris
approved these changes
May 13, 2024
| public void init() { | ||
| functionName = "detectLanguage"; | ||
| } | ||
| String functionName = "detectLanguage"; |
There was a problem hiding this comment.
This seems a little odd, but I guess it comes from the previous code.
wetneb
added a commit
that referenced
this pull request
May 16, 2024
Caused by merging #6571 which was already a bit old
|
Merging this broke the build because of a missing import, so I am adding it directly to master with 6a86001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
RefineTest. This makes it possible to remove the test utilities that depend on GREL from the RefineTest class, in anticipation for it being in a core Maven module where GREL isn't availableEvalErrorTestsbut really belong to the test classes for the functions they actually test. This is also necessary becauseEvalErrorwill live in the core Maven module (being part of the core data model, as they can be stored in Cell), whereas the corresponding functions will be in the GREL module