Remove grel registration from RefineTest #6574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wetneb
changed the title
wetneb
force-pushed
the
remove_grel_registration_from_refinetest
branch
from
2c9b61f
to
4aa19e9
Compare
Add it to each test that requires it instead.
wetneb
force-pushed
the
remove_grel_registration_from_refinetest
branch
from
4aa19e9
to
08804c3
Compare
tfmorris
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the final dependency from RefineTest to GREL by not registering GREL in it by default.
Instead, we register and unregister it in each test that relies on it.
Draft because it depends on #6502 and #6571. Once those are merged, the diffs will be smaller.