Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix conan install of cpython #540

Merged
merged 1 commit into from Jul 28, 2022

Commits on Jul 27, 2022

  1. [Tests] Fix conan install of cpython

    Due to a new `xorg/system` recipe, which the cpython recipe depends on,
    the `conan install` step on CI (and Vagrant) fails attempting to
    install system packages (i.e. `apt` packages).
    
    This is because the `xorg/system` recipe has been refactored and will
    now always try to install the latest version of system packages, even
    if they are already available.
    
    The default conan mode in this case is to only "check" if packages are
    installed and throw an error if they're not found (the alternative
    behaviour being to "install" if not found). However, this has a bug
    (reported and hopefully fixed in
    conan-io/conan#11712), whereby if the recipe has
    specified to `apt-get update` (or platform-specific equivalent) before
    installing, then conan always tries and throws an error if in "check"
    mode.
    
    So switch to "install" mode, which will cause a pointless
    `apt-get update` followed by
    > xorg/system: System requirements:  already installed
    during the conan install.
    
    Also extracted the list of system packages required by the latest
    `xorg/system` recipe and updated the package list in our bootstrap
    script.
    
    Added a TODO to revisit this once conan 1.51 is released, where this
    problem should be fixed.
    
    Signed-off-by: David Feltell <david.feltell@foundry.com>
    feltech committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    d9b1870 View commit details
    Browse the repository at this point in the history