refactor: store Orbit chains as json #1665
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brtkx
commented
May 9, 2024
There was a problem hiding this comment.
This file is the removed orbitChainsList.ts file (and renamed) and Orbit chains are removed from here. These chains are now part of json configs.
…e into store-orbits-json
5 tasks
…token-bridge into store-orbits-json
…e into store-orbits-json
brtkx
commented
May 24, 2024
| @@ -0,0 +1,304 @@ | |||
| { | |||
There was a problem hiding this comment.
Please double check that I didn't miss an Orbit chain while migrating, because I was resolving some conflicts too.
Also, pls compare old data against the new.
spsjvc
reviewed
May 24, 2024
| .refine(bool => bool === true, 'Invalid input, must be true') | ||
|
|
||
| function validateOrbitChain(chain: OrbitChainConfig) { | ||
| try { |
There was a problem hiding this comment.
now that we're validating this in prebuild, we want it to throw when there's an error, so let's remove try/catch
There was a problem hiding this comment.
we throw in the catch block, we just want to show info about the chain name/ID first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A requirement for #1664. Need to store Orbit chains as json so that the workflow can easily update it.