Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove process isolation from tests around file writer generators #486

Merged
merged 8 commits into from Aug 10, 2019
Merged

Remove process isolation from tests around file writer generators #486

merged 8 commits into from Aug 10, 2019

Commits on Aug 10, 2019

  1. Disallow PHPUnit 8.3.0 due to sebastianbergmann/phpunit#3772 

    As discussed with @sebastianbergmann, PHPUnit 8.3.4 may fix this issue, but until then,
we lock onto an older version to have green builds to validate a release
    @Ocramius
    Ocramius committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    445a713 View commit details
    Browse the repository at this point in the history

  2. Revert "Disallow PHPUnit 8.3.0 due to sebastianbergmann/phpunit#3772" 

    This reverts commit 445a713.
    @Ocramius
    Ocramius committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    4714f9e View commit details
    Browse the repository at this point in the history

  3. Remove usage of @runTestsInSeparateProcesses - drop testing around … 

    …'open_basedir' ini settings

If you use `ini_set('open_basedir', ...)`, you are on your own, and you are really just hurting yourself.

Stop relying on shared hosting, and deploy a proper isolated/virtualized environment if you got a real application.
    @Ocramius
    Ocramius committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    ec70747 View commit details
    Browse the repository at this point in the history

  4. Removed untested trim() operation 

    This particular `trim()` also cannot be tested, since a namespace containing
a leading/trailing `T_NAMESPACE_SEPARATOR` would lead `zendframework/zend-code`
to generate invalid code.

This has to be fixed upstream, by using stricter types instead.
    @Ocramius
    Ocramius committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    ceee6b3 View commit details
    Browse the repository at this point in the history

  5. Removed untested trim() operation 

    This particular `trim()` also cannot be tested, since a class containing
a leading/trailing `T_NAMESPACE_SEPARATOR` would lead `zendframework/zend-code`
to generate invalid code.

This has to be fixed upstream, by using stricter types instead.
    @Ocramius
    Ocramius committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    e98164d View commit details
    Browse the repository at this point in the history

  6. Hardening tests around error handlers in FileWriterGeneratorStrategy

    @Ocramius
    Ocramius committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    ef182a9 View commit details
    Browse the repository at this point in the history

  7. Covering Properties#withoutNonReferenceableProperties() (deprecated)

    @Ocramius
    Ocramius committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    a1ba576 View commit details
    Browse the repository at this point in the history

  8. Applied automatic CS fixes and fixing resulting static analysis issues

    @Ocramius
    Ocramius committed Aug 10, 2019
    Configuration menu
    Copy the full SHA
    0e1ac25 View commit details
    Browse the repository at this point in the history