Remove process isolation from tests around file writer generators #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with @sebastianbergmann, PHPUnit 8.3.4 may fix this issue, but until then, we lock onto an older version to have green builds to validate a release
Ocramius
changed the title
|
Hmm, doesn't seem to be the culprit... |
This reverts commit 445a713.
…'open_basedir' ini settings
If you use `ini_set('open_basedir', ...)`, you are on your own, and you are really just hurting yourself.
Stop relying on shared hosting, and deploy a proper isolated/virtualized environment if you got a real application.
Ocramius
changed the title
This particular `trim()` also cannot be tested, since a namespace containing a leading/trailing `T_NAMESPACE_SEPARATOR` would lead `zendframework/zend-code` to generate invalid code. This has to be fixed upstream, by using stricter types instead.
This particular `trim()` also cannot be tested, since a class containing a leading/trailing `T_NAMESPACE_SEPARATOR` would lead `zendframework/zend-code` to generate invalid code. This has to be fixed upstream, by using stricter types instead.
|
GREEN! FINALLY! |
Ocramius
deleted the
fix/avoid-phpunit-8.3-due-to-phpdbg-process-isolation-bugs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sebastianbergmann/phpunit#3772
As discussed with @sebastianbergmann, PHPUnit 8.3.4 may fix this issue, but until then,we lock onto an older version to have green builds to validate a release
For now, we simply remove process isolation to simplify the issue overall