Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try running PHPUnit like Infection does #483

Closed
wants to merge 4 commits into from

Conversation

sanmai
Copy link

@sanmai sanmai commented Aug 2, 2019

@sanmai sanmai closed this Aug 2, 2019
@Ocramius
Copy link
Owner

Ocramius commented Aug 2, 2019

@sanmai no luck? I'm also kinda clueless on what's going on...

@sanmai sanmai reopened this Aug 2, 2019
@sanmai
Copy link
Author

sanmai commented Aug 2, 2019

OK, let's see if PHPUnit tells us exactly where this is happening.

@sanmai
Copy link
Author

sanmai commented Aug 2, 2019

Interestingly it now gives a slightly different explanation for the errors. E.g. before it was:

1) ProxyManagerTest\GeneratorStrategy\FileWriterGeneratorStrategyTest::testGenerate
PHPUnit\Framework\Exception: Notice: stream_get_contents(): read of 8192 bytes failed with errno=9 Bad file descriptor in Standard input code on line 321

And now:

1) ProxyManagerTest\GeneratorStrategy\FileWriterGeneratorStrategyTest::testGenerate
PHPUnit\Framework\Exception: [Nothing to execute!]

Caused by
ErrorException: unserialize(): Error at offset 0 of 33 bytes in /home/travis/build/Ocramius/ProxyManager/vendor/phpunit/phpunit/src/Util/PHP/AbstractPhpProcess.php:271

PHP version is the same: PHP 7.4.0-dev (cli) (built: Aug 1 2019 09:31:11) ( ZTS )

@sanmai
Copy link
Author

sanmai commented Aug 2, 2019

So far I'm unable to reproduce the issue locally with PHP 7.4.0-dev (cli) (built: Aug 1 2019 23:23:35) ( NTS )

NTS vs. ZTS might have something about it. Still no luck with PHP 7.4.0beta1 (cli) (built: Jul 27 2019 01:44:06) ( ZTS ).

@sanmai
Copy link
Author

sanmai commented Aug 2, 2019

But I was trying PHPUnit 8.2.5, and these builds are with 8.3. Starting all over.

@sanmai
Copy link
Author

sanmai commented Aug 2, 2019

All right, now I can reproduce this issue on Docker with php:7.4-rc-cli.

@sanmai
Copy link
Author

sanmai commented Aug 2, 2019

Since we have a reproducible case, I took liberty to report this to the upstream as sebastianbergmann/phpunit#3772. Hope you won't mind.

@sanmai sanmai closed this Aug 2, 2019
@sanmai
Copy link
Author

sanmai commented Aug 2, 2019

So you'll have to stay away from 8.3.0 while you use PHPDBG, support for it seems to be on the verge of abandonment.

@Ocramius
Copy link
Owner

Ocramius commented Aug 2, 2019

Thanks for all this hard work, @sanmai!

Sad for PHPDBG - it started to become more reliable (although not much)

@sanmai
Copy link
Author

sanmai commented Aug 5, 2019

Sounds like the claim to drop support for PHPDBG was withdraw. Thanks for the sound argument for keeping it!

@sanmai sanmai deleted the patch-1 branch August 5, 2019 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants