New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flatbuffers: 2.0.7 -> unstable-2022-09-11 #190727
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
superherointj
changed the title
flatbuffers: bump to latest master commit for cmake fix
flatbuffers: 2.0.7 -> unstable-2022-09-11
Sep 10, 2022
PR title and commit message does not comply with standard. https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#submitting-changes |
Algram
force-pushed
the
fix/flatbuffers-cmake
branch
2 times, most recently
from
September 10, 2022 22:48
de43713
to
0583b65
Compare
New version with fix for the cmake integration has not yet been released: google/flatbuffers#7499.
Algram
force-pushed
the
fix/flatbuffers-cmake
branch
from
September 10, 2022 22:49
0583b65
to
5379109
Compare
Result of 25 packages marked as broken and skipped:
281 packages failed to build:
|
@Algram Too many packages are breaking. You'd have to investigate it. Maybe wait for next release? Still, have a look. |
The cmake fix is included in v22.9.24 (#188951) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Flatbuffers had a broken cmake integration a few commits ago. It is fixed on master, but there is no new release yet. Here is a temporary fix for that by directly grabbing the latest master commit.
google/flatbuffers#7499
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes