Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flatbuffers: 2.0.7 -> unstable-2022-09-11 #190727

Closed
wants to merge 1 commit into from

Conversation

Algram
Copy link
Member

@Algram Algram commented Sep 10, 2022

Description of changes

Flatbuffers had a broken cmake integration a few commits ago. It is fixed on master, but there is no new release yet. Here is a temporary fix for that by directly grabbing the latest master commit.

google/flatbuffers#7499

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@superherointj superherointj changed the title flatbuffers: bump to latest master commit for cmake fix flatbuffers: 2.0.7 -> unstable-2022-09-11 Sep 10, 2022
@superherointj
Copy link
Contributor

superherointj commented Sep 10, 2022

PR title and commit message does not comply with standard.

https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#submitting-changes

@Algram Algram force-pushed the fix/flatbuffers-cmake branch 2 times, most recently from de43713 to 0583b65 Compare September 10, 2022 22:48
New version with fix for the cmake integration has not yet been released: google/flatbuffers#7499.
@superherointj
Copy link
Contributor

Result of nixpkgs-review pr 190727 run on x86_64-linux 1

25 packages marked as broken and skipped:
  • flatbuffers_2_0
  • intensity-normalization
  • kodiGBM
  • kodiPlain
  • kodiPlainWayland
  • paperless
  • paperless-ng
  • python310Packages.caffe
  • python310Packages.caffeWithCuda
  • python310Packages.imgaug
  • python310Packages.intensity-normalization
  • python310Packages.mask-rcnn
  • python310Packages.optuna
  • python310Packages.pymc3
  • python310Packages.rl-coach
  • python310Packages.tensorflow-bin_2
  • python310Packages.tensorflow-build_2
  • python39Packages.imgaug
  • python39Packages.intensity-normalization
  • python39Packages.mask-rcnn
  • python39Packages.optuna
  • python39Packages.pymc3
  • python39Packages.rl-coach
  • python39Packages.tensorflow-bin_2
  • python39Packages.tensorflow-build_2
281 packages failed to build:
  • arrow-cpp
  • arrow-glib
  • baserow
  • buildbot (python310Packages.buildbot)
  • buildbot-full (python310Packages.buildbot-full)
  • buildbot-ui (python310Packages.buildbot-ui)
  • buildbot-worker (python310Packages.buildbot-worker)
  • flatbuffers
  • gnome-keysign
  • gpt2tc
  • grab-site
  • home-assistant-component-tests.environment_canada
  • hyperion-ng
  • kodi (kodiPackages.kodi)
  • kodi-gbm
  • kodi-wayland
  • kodiPackages.a4ksubtitles
  • kodiPackages.archive_tool
  • kodiPackages.iagl
  • kodiPackages.inputstream-adaptive
  • kodiPackages.inputstream-ffmpegdirect
  • kodiPackages.inputstream-rtmp
  • kodiPackages.invidious
  • kodiPackages.joystick
  • kodiPackages.kodi-platform
  • kodiPackages.libretro
  • kodiPackages.libretro-genplus
  • kodiPackages.libretro-mgba
  • kodiPackages.libretro-snes9x
  • kodiPackages.netflix
  • kodiPackages.pvr-hdhomerun
  • kodiPackages.pvr-hts
  • kodiPackages.pvr-iptvsimple
  • kodiPackages.steam-controller
  • kodiPackages.vfs-libarchive
  • kodiPackages.vfs-sftp
  • libtensorflow
  • magic-wormhole (python310Packages.magic-wormhole)
  • napari (python310Packages.napari)
  • paperless-ngx
  • parquet-tools
  • python310Packages.aeppl
  • python310Packages.aesara
  • python310Packages.apache-beam
  • python310Packages.aplpy
  • python310Packages.arviz
  • python310Packages.asdf
  • python310Packages.astroquery
  • python310Packages.augmax
  • python310Packages.autobahn
  • python310Packages.baselines
  • python310Packages.batchgenerators
  • python310Packages.boxx
  • python310Packages.bpycv
  • python310Packages.bsuite
  • python310Packages.casa-formats-io
  • python310Packages.channels
  • python310Packages.channels-redis
  • python310Packages.chex
  • python310Packages.clifford
  • python310Packages.dalle-mini
  • python310Packages.daphne
  • python310Packages.dask
  • python310Packages.dask-gateway
  • python310Packages.dask-glm
  • python310Packages.dask-image
  • python310Packages.dask-jobqueue
  • python310Packages.dask-ml
  • python310Packages.dask-mpi
  • python310Packages.dask-yarn
  • python310Packages.datafusion
  • python310Packages.datasets
  • python310Packages.datashader
  • python310Packages.db-dtypes
  • python310Packages.devito
  • python310Packages.distrax
  • python310Packages.distributed
  • python310Packages.dm-haiku
  • python310Packages.dm-sonnet
  • python310Packages.dremel3dpy
  • python310Packages.edward
  • python310Packages.elegy
  • python310Packages.env-canada
  • python310Packages.flatbuffers
  • python310Packages.flax
  • python310Packages.glymur
  • python310Packages.google-cloud-bigquery
  • python310Packages.gpt-2-simple
  • python310Packages.handout
  • python310Packages.ibis-framework
  • python310Packages.image-match
  • python310Packages.imagecorruptions
  • python310Packages.imageio
  • python310Packages.intake
  • python310Packages.intake-parquet
  • python310Packages.jax
  • python310Packages.jaxlib (python310Packages.jaxlibWithoutCuda)
  • python310Packages.jaxlib-bin
  • python310Packages.jaxlibWithCuda
  • python310Packages.jmp
  • python310Packages.labgrid
  • python310Packages.magic-wormhole-mailbox-server
  • python310Packages.magic-wormhole-transit-relay
  • python310Packages.moviepy
  • python310Packages.napari-console
  • python310Packages.napari-svg
  • python310Packages.numpyro
  • python310Packages.objax
  • python310Packages.optax
  • python310Packages.pims
  • python310Packages.pot
  • python310Packages.psd-tools
  • python310Packages.pyarrow
  • python310Packages.pyfftw
  • python310Packages.pymanopt
  • python310Packages.pymc
  • python310Packages.pyregion
  • python310Packages.pytest-astropy
  • python310Packages.pytest-astropy-header
  • python310Packages.pyvo
  • python310Packages.qiskit
  • python310Packages.qiskit-machine-learning
  • python310Packages.recordlinkage
  • python310Packages.reproject
  • python310Packages.rlax
  • python310Packages.runway-python
  • python310Packages.scikit-tda
  • python310Packages.scikitimage
  • python310Packages.slicedimage
  • python310Packages.spacy-transformers
  • python310Packages.sparse
  • python310Packages.spectral-cube
  • python310Packages.streamz
  • python310Packages.stumpy
  • python310Packages.stytra
  • python310Packages.sunpy
  • python310Packages.tensorflow (python310Packages.tensorflowWithoutCuda)
  • python310Packages.tensorflow-bin
  • python310Packages.tensorflow-datasets
  • python310Packages.tensorflow-probability
  • python310Packages.tensorflowWithCuda
  • python310Packages.tensorly
  • python310Packages.test-tube
  • python310Packages.tflearn
  • python310Packages.tifffile
  • python310Packages.tokenizers
  • python310Packages.transformers
  • python310Packages.treeo
  • python310Packages.treex
  • python310Packages.trfl
  • python310Packages.umap-learn
  • python310Packages.vqgan-jax
  • python310Packages.zcs
  • python39Packages.aeppl
  • python39Packages.aesara
  • python39Packages.apache-beam
  • python39Packages.aplpy
  • python39Packages.arviz
  • python39Packages.asdf
  • python39Packages.astroquery
  • python39Packages.augmax
  • python39Packages.autobahn
  • python39Packages.baselines
  • python39Packages.batchgenerators
  • python39Packages.boxx
  • python39Packages.bpycv
  • python39Packages.bsuite
  • python39Packages.buildbot
  • python39Packages.buildbot-full
  • python39Packages.buildbot-ui
  • python39Packages.buildbot-worker
  • python39Packages.caffe
  • python39Packages.caffeWithCuda
  • python39Packages.casa-formats-io
  • python39Packages.channels
  • python39Packages.channels-redis
  • python39Packages.chex
  • python39Packages.clifford
  • python39Packages.dalle-mini
  • python39Packages.daphne
  • python39Packages.dask
  • python39Packages.dask-gateway
  • python39Packages.dask-glm
  • python39Packages.dask-image
  • python39Packages.dask-jobqueue
  • python39Packages.dask-ml
  • python39Packages.dask-mpi
  • python39Packages.dask-yarn
  • python39Packages.datafusion
  • python39Packages.datasets
  • python39Packages.datashader
  • python39Packages.db-dtypes
  • python39Packages.devito
  • python39Packages.distrax
  • python39Packages.distributed
  • python39Packages.dm-haiku
  • python39Packages.dm-sonnet
  • python39Packages.dremel3dpy
  • python39Packages.edward
  • python39Packages.elegy
  • python39Packages.env-canada
  • python39Packages.flatbuffers
  • python39Packages.flax
  • python39Packages.glymur
  • python39Packages.google-cloud-bigquery
  • python39Packages.gpt-2-simple
  • python39Packages.handout
  • python39Packages.ibis-framework
  • python39Packages.image-match
  • python39Packages.imagecorruptions
  • python39Packages.imageio
  • python39Packages.intake
  • python39Packages.intake-parquet
  • python39Packages.jax
  • python39Packages.jaxlib (python39Packages.jaxlibWithoutCuda)
  • python39Packages.jaxlib-bin
  • python39Packages.jaxlibWithCuda
  • python39Packages.jmp
  • python39Packages.labgrid
  • python39Packages.magic-wormhole
  • python39Packages.magic-wormhole-mailbox-server
  • python39Packages.magic-wormhole-transit-relay
  • python39Packages.moviepy
  • python39Packages.napari
  • python39Packages.napari-console
  • python39Packages.napari-svg
  • python39Packages.numpyro
  • python39Packages.objax
  • python39Packages.optax
  • python39Packages.pims
  • python39Packages.pot
  • python39Packages.psd-tools
  • python39Packages.pyarrow
  • python39Packages.pyfftw
  • python39Packages.pymanopt
  • python39Packages.pymc
  • python39Packages.pyregion
  • python39Packages.pytest-astropy
  • python39Packages.pytest-astropy-header
  • python39Packages.pyvo
  • python39Packages.qiskit
  • python39Packages.qiskit-machine-learning
  • python39Packages.recordlinkage
  • python39Packages.reproject
  • python39Packages.rlax
  • python39Packages.runway-python
  • python39Packages.scikit-tda
  • python39Packages.scikitimage
  • python39Packages.slicedimage
  • python39Packages.spacy-transformers
  • python39Packages.sparse
  • python39Packages.spectral-cube
  • python39Packages.streamz
  • python39Packages.stumpy
  • python39Packages.stytra
  • python39Packages.sunpy
  • python39Packages.tensorflow (python39Packages.tensorflowWithoutCuda)
  • python39Packages.tensorflow-bin
  • python39Packages.tensorflow-datasets
  • python39Packages.tensorflow-probability
  • python39Packages.tensorflowWithCuda
  • python39Packages.tensorly
  • python39Packages.test-tube
  • python39Packages.tflearn
  • python39Packages.tifffile
  • python39Packages.tokenizers
  • python39Packages.transformers
  • python39Packages.treeo
  • python39Packages.treex
  • python39Packages.trfl
  • python39Packages.umap-learn
  • python39Packages.vqgan-jax
  • python39Packages.zcs
  • rpcs3
  • streamlit
  • tahoe-lafs
  • tartube
  • tartube-yt-dlp
  • tensorflow-lite
  • tts
  • vowpal-wabbit

@superherointj
Copy link
Contributor

@Algram Too many packages are breaking. You'd have to investigate it. Maybe wait for next release? Still, have a look.

@kevinmehall
Copy link
Contributor

The cmake fix is included in v22.9.24 (#188951)

@mweinelt mweinelt closed this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants