obs-studio-plugins.obs-hyperion: fix build

[Algram]

Description of changes

Missed the qtbase call during packaging. This fixes the plugin.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[superherointj]

Result of nixpkgs-review pr 190721 run on x86_64-linux 1

1 package failed to build:

• obs-studio-plugins.obs-hyperion

[Algram]

Hm I don't really know how to fix it then, could you maybe try and have a look? Locally it works like this:

I don't know how to properly make it work in the repo though.

EDIT: I think the review tool just does not work? It tries to grab the plugin from gitlab.

[superherointj]

Result of nixpkgs-review pr 190721 run on x86_64-linux 1

1 package failed to build:

• obs-studio-plugins.obs-hyperion

[superherointj]

Try:

rev = version;

[superherointj]

Result of nixpkgs-review pr 190721 run on x86_64-linux 1

1 package failed to build:

• obs-studio-plugins.obs-hyperion

[superherointj]

Result of nixpkgs-review pr 190721 run on x86_64-linux 1

1 package failed to build:

• obs-studio-plugins.obs-hyperion

[Algram]

I think it will start working now once flatbuffers gets released with the fix here:
google/flatbuffers#7499

It is fixed on master but not on their latest version.

[superherointj]

Result of nixpkgs-review pr 190721 run on x86_64-linux 1

1 package failed to build:

• obs-studio-plugins.obs-hyperion

[Algram]

@superherointj Any pointers on how to test that locally? I can test flatbuffers to master, but how to make my package use that then?

[superherointj]

Notice: I am lacking context on this.

You could bump flatbuffers (in general). No?

[Algram]

@superherointj I could, but I would need to set it to master and not a specific version. Is that accepted in general? If yes, I can commit that. But even if I commit. How can I test it before merging?

[superherointj]

@superherointj I could, but I would need to set it to master and not a specific version. Is that accepted in general? If yes, I can commit that. But even if I commit. How can I test it before merging?

Yes, set version to unstable-YYYY-MM-DD (commit date) and rev to commit hash.

Make it in a different PR. And reference this one as explanation.

[superherointj]

On every PR, always use nixpkgs-review to validate downstream breakage, and repeat it's use after every change.
You should have been using it already.
Skip using it for staging.

[Algram]

Alright I will split it up into a separate PR.

[Algram]

Depends on: #190727

[superherointj]

Feel free to integrate and squash my changes here.

[Algram]

Will be fixed in this PR: #198198