Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.starlette: 0.13.8 -> 0.14.2 #112701

Merged
merged 1 commit into from Mar 20, 2021
Merged

python3Packages.starlette: 0.13.8 -> 0.14.2 #112701

merged 1 commit into from Mar 20, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change

https://github.com/encode/starlette/releases/tag/0.14.0
https://github.com/encode/starlette/releases/tag/0.14.1
https://github.com/encode/starlette/releases/tag/0.14.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from wd15 February 11, 2021 02:20
@r-rmcgibbo

This comment has been minimized.

Sign in to view
@r-rmcgibbo

This comment has been minimized.

Sign in to view
@mweinelt
Copy link
Member Author

Rebased, because nixpkgs-review by @r-rmcgibbo didn't take the uvloop fixes on the target branch into account.

Result of nixpkgs-review pr 112701 run on x86_64-linux 1

2 packages failed to build:
  • python37Packages.fastapi
  • python38Packages.fastapi
3 packages built:
  • python37Packages.starlette
  • python38Packages.starlette
  • python39Packages.starlette

@rmcgibbo
Copy link
Contributor

Sorry about that

@fabaff
Copy link
Member

fabaff commented Feb 11, 2021

Result of nixpkgs-review pr 112701 run on x86_64-linux 1

2 packages failed to build:
  • python37Packages.fastapi
  • python38Packages.fastapi
3 packages built:
  • python37Packages.starlette
  • python38Packages.starlette
  • python39Packages.starlette

fabaff
fabaff approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

...ew/pr-112701/results/python38Packages.starlette/lib/python3.8/site-packages]$ python
Python 3.7.9 (default, Aug 15 2020, 06:36:35) 
[GCC 10.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import starlette
>>> starlette.__version__
'0.14.2'
...ew/pr-112701/results/python38Packages.starlette/lib/python3.8/site-packages]$ python example.py
INFO:     Started server process [4522]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://127.0.0.1:5000 (Press CTRL+C to quit)

Looks good to me.

@mweinelt
Copy link
Member Author

Sorry about that

Not actually your fault, the fixes arrived on master three minutes after this pull request was opened. I was merely stating the fact, that they didn't (couldn't) take that into account.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 112701 run on x86_64-linux 1

2 packages failed to build and are new build failures:
3 packages built:
  • python37Packages.starlette
  • python38Packages.starlette
  • python39Packages.starlette

@mweinelt
Copy link
Member Author

Because fastapi is the only consumer of starlette, I'd say we wait for feedback from fastapi maintainers.

@mweinelt mweinelt added the 2.status: wait-for-upstream Waiting for upstream fix (or their other action). label Feb 11, 2021
@oxzi
Copy link
Member

oxzi commented Feb 22, 2021

The latest platformio release requires a starlette version of 0.14.x. Thus, I'd love to this one merged.

@oxzi oxzi mentioned this pull request Feb 22, 2021
Merged
13 tasks
@wd15
Copy link
Contributor

wd15 commented Mar 3, 2021

It seems sensible to disable FastAPI as it has been stuck at 0.13.x of Starlette for quite some time. FastAPI also fixes the exact Starlette bug fix version, which doesn't work well with Nixpkgs. There is an open FastAPI PR that hasn't been reviewed since December. So, I'm in favor of disabling FastAPI and updating Starlette especially if Starlette's dependencies are blocked.

@mweinelt
python3Packages.starlette: 0.13.8 -> 0.14.2
f899f3a 
- ujson was dropped in encode/starlette#1047
- test_debug_html was fixed in encode/starlette#1132
@mweinelt
Copy link
Member Author

Result of nixpkgs-review pr 112701 run on x86_64-linux 1

2 packages failed to build:
  • python38Packages.fastapi
  • python39Packages.fastapi
2 packages built:
  • python38Packages.starlette
  • python39Packages.starlette

@mweinelt mweinelt merged commit d9bc0ec into NixOS:master Mar 20, 2021
@mweinelt mweinelt deleted the python/starlette branch March 20, 2021 00:55
@wd15 wd15 mentioned this pull request Apr 14, 2021
Merged
10 tasks
@AluisioASG AluisioASG mentioned this pull request Apr 30, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabaff fabaff fabaff approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@wd15 wd15 Awaiting requested review from wd15

Assignees
No one assigned
Labels
2.status: wait-for-upstream Waiting for upstream fix (or their other action). 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mweinelt @r-rmcgibbo @rmcgibbo @fabaff @SuperSandro2000 @oxzi @wd15