Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: 5.0.4 -> 5.1.1 #114014

Merged
merged 1 commit into from May 17, 2021
Merged

platformio: 5.0.4 -> 5.1.1 #114014

merged 1 commit into from May 17, 2021

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Feb 22, 2021 •
edited

Motivation for this change

Update platformio to its latest release. However, to get this changes working, the following pull requests needed to be merged first:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@ofborg eval

@oxzi oxzi mentioned this pull request Mar 18, 2021
Merged
10 tasks
@oxzi oxzi changed the title platformio: 5.0.4 -> 5.1.0 platformio: 5.0.4 -> 5.1.` Mar 18, 2021
@oxzi oxzi changed the title platformio: 5.0.4 -> 5.1.` platformio: 5.0.4 -> 5.1.1 Mar 18, 2021
@oxzi
Copy link
Member Author

oxzi commented Mar 18, 2021

I have updated and rebased this pull request for PlatformIO's latest release 5.1.1. This introduced a new dependency, ajsonrpc, for which I created another PR #116727. However, to make this changes work, the starlette package update needs to be merged first, #112701.

I have successfully tested this package with those two changes applied locally.

@oxzi
Copy link
Member Author

oxzi commented Mar 22, 2021

After all necessary dependencies were merged, I rebased this PR once again and now it should be ready for a final review.

@oxzi oxzi marked this pull request as ready for review March 22, 2021 13:07
@leonardp
Copy link

FWIW I have also tested this locally and it is working as intended.

@oxzi
Copy link
Member Author

oxzi commented May 2, 2021

@SuperSandro2000: Would you please take another look? Thanks!

@happysalada
Copy link
Contributor

Result of nixpkgs-review pr 114014 run on x86_64-darwin 1

@happysalada
Copy link
Contributor

The PR looks good to me, doesn't seem to be a major change anyway.
I'm going to go ahead and merge this considering everybody is busy with the coming release

@happysalada happysalada merged commit 7347900 into NixOS:master May 17, 2021
@oxzi oxzi deleted the platformio-5.1.0 branch May 21, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @SuperSandro2000 @leonardp @happysalada