FilteringTargetWrapper: Add support for batch writing + PostFilteringTargetWrapper: performance optimizations

[snakefoot]

And allow use of WhenRepeated as Filter:

      <target name="default" xsi:type="FilteringWrapper">
        <filter xsi:type="whenRepeated" layout="${message}" timeoutSeconds="30" action="Ignore" />
        <target name="console" xsi:type="Console" />
      </target>

Also made some optimizations to PostFilteringTargetWrapper so it also supports OptimizeBufferReuse = true.

And also "fixed" PostFilteringTargetWrapper so it also works when writing a single LogEvent, without using BufferingWrapper or AsyncWrapper (More intuitive and user-friendly)

[codecov-io]

Codecov Report

Merging #3405 into master will increase coverage by <1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3405    +/-   ##
=======================================
+ Coverage      80%     80%   +<1%     
=======================================
  Files         356     357     +1     
  Lines       28205   28281    +76     
  Branches     3750    3769    +19     
=======================================
+ Hits        22559   22660   +101     
+ Misses       4540    4535     -5     
+ Partials     1106    1086    -20

[304NotModified]

Thanks!

Is this a Breaking change? (Removal of ConditionExpression Condition)

[snakefoot]

Is this a Breaking change? (Removal of ConditionExpression Condition)

No breaking change. The existing property:

public ConditionExpression Condition { get; set; }

Is now forwarding into the new Filter-property using ConditionBasedFilter as wrapper

[snakefoot]

@304NotModified Please include for ver. 4.6.4

[304NotModified]

It would be nice if we could deduplicate PostFilteringTargetWrapper.ApplyFilter and FilteringTargetWrapper.Write - any idea how?

[snakefoot]

It would be nice if we could deduplicate PostFilteringTargetWrapper.ApplyFilter and FilteringTargetWrapper.Write - any idea how?

Made a commit

[304NotModified]

cool,

what do you think of snakefoot#8 ? Or are lambdas bad for performance?

[snakefoot]

Or are lambdas bad for performance?

Yes bad for performance when doing capture. Was also doing it first (With delegate-caching). Until the other target comes with a dynamic-filter-object. Then it became a TState-parameter (Because delegate-caching was not easy).

[304NotModified]

OK! Added some docs and now this is perfect IMO :)

[snakefoot]

OK! Added some docs and now this is perfect IMO :)

Also happy with the result :)

[snakefoot]

@304NotModified Guess you need to restart the appveyor-build

[304NotModified]

restarted 2nd time 👼

[304NotModified]

Oops the idea was to merge this on to release/4.6.4. Anyway, canceled the build so no problem.

[snakefoot]

Updated the documentation: https://github.com/NLog/NLog/wiki/FilteringWrapper-target and added link from https://github.com/NLog/NLog/wiki/WhenRepeated-Filter

[304NotModified]

Ah this is also a xsd update