Various XSD improvements (NLog.Schema package)

[304NotModified]

fixes #3377

• fix LoggerName

related #2394 and #2891

[snakefoot]

@304NotModified Think you should also fix this method to recognize RULENAME:

        private LoggingRule ParseRuleElement(ILoggingConfigurationElement loggerElement)
        {
            IEnumerable<LogLevel> enableLevels = null;
            int minLevel = 0;
            int maxLevel = LogLevel.MaxLevel.Ordinal;

            string ruleName = null;
            string namePattern = null;
            bool enabled = true;
            bool final = false;
            string writeTargets = null;
            foreach (var childProperty in loggerElement.Values)
            {
                switch (childProperty.Key?.Trim().ToUpperInvariant())
                {
                    case "NAME":
                        if (loggerElement.MatchesName("logger"))
                            namePattern = childProperty.Value; // Legacy Style
                        else
                            ruleName = childProperty.Value;
                        break;
                    case "RULENAME":
                        ruleName = childProperty.Value; // Legacy Style
                        break;

[304NotModified]

@304NotModified Think you should also fix this method to recognize RULENAME:

This isn't an issue in the XML now isn't?

[304NotModified]

I think we have to update the XSD for NLog 5 and recommend the new approach IMO

[snakefoot]

This isn't an issue in the XML now isn't?

Nope but it would make sense that rulename is recognized by the parser, when adding it to the xml-doc :)

[304NotModified]

ow this is a mistake then. I'm confused why the names aren't in sync...

[codecov-io]

Codecov Report

Merging #3409 into release/4.6.4 will increase coverage by <1%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           release/4.6.4   #3409    +/-   ##
==============================================
+ Coverage             80%     80%   +<1%     
==============================================
  Files                358     358            
  Lines              28373   28378     +5     
  Branches            3785    3786     +1     
==============================================
+ Hits               22750   22763    +13     
+ Misses              4537    4521    -16     
- Partials            1086    1094     +8

[snakefoot]

Created #3411