Code that could get some coverage

[304NotModified]

Parts with some lower test coverage

• TargetWithContext.cs - coverage
• DebuggerTarget.cs coverage
• NetworkSenders/ - coverage
  • HttpNetworkSender -> replace WebRequest.Create with custom IWebRequestFactory?
  • NetworkSender - coverage
  • NetworkSenderFactory- coverage
• LogReceiverService/ - coverage
• (lower prio) AsyncTaskTarget.cs - coverage
• GarbageCollectorInfoLayoutRenderer coverage
• (easy) MessageTemplateParameter PositionalIndex coverage
• (easy) ValueFormatter coverage
  • render null
  • handle cycle
• MessageTemplateParameters IsPositional+IsValidTemplate + TemplateParserException coverage
• (low priority, easy) TimeSource tostring
• LogLevel - Added support for TypeConverter #3469 (TypeConverter) coverage

[aerotog]

The TypeConverter class, LogLevelTypeConverter, has 88% code coverage via the test LogLevelConvertTest in LogLevelTests. I don't see it in your coverage report so I'm wondering if it actually need more coverage added or if it could already be considered complete. I suppose it might benefit to move the test into its own dedicated test class to make the coverage more obvious.

Also, could you elaborate on what the these requested test cases mean:

• (easy) ValueFormatter coverage
  • render null
  • handle cycle

[304NotModified]

The TypeConverter class, LogLevelTypeConverter, has 88% code coverage via the test LogLevelConvertTest in LogLevelTests. I don't see it in your coverage report so I'm wondering if it actually need more coverage added or if it could already be considered complete. I suppose it might benefit to move the test into its own dedicated test class to make the coverage more obvious.

I have to check that, maybe it's done already indeed.

Also, could you elaborate on what the these requested test cases mean:

• (easy) ValueFormatter coverage

  • render null
  • handle cycle

null prints "NULL", and objects with recursion (cycles) will rendered correctly (and not infinite looping).

Thanks in advance!

[aerotog]

Took the two easy ones. I might come back and try some other classes later this week.