Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make HttpNetworkSender mockable, add unit test, introduce NSubsitute #3274

Merged
merged 3 commits into from
Apr 4, 2019
Merged

Make HttpNetworkSender mockable, add unit test, introduce NSubsitute #3274

merged 3 commits into from
Apr 4, 2019

Conversation

304NotModified
Copy link
Member

@304NotModified 304NotModified commented Apr 3, 2019 •
edited

Part of #3181

todo

  • split files
  • maybe remove some mocks and replace them with NSubsitute
  • cleanup
  • check coverage

@codecov
Copy link

codecov bot commented Apr 3, 2019 •
edited

Codecov Report

Merging #3274 into dev will increase coverage by 1%.
The diff coverage is 33%.

@@           Coverage Diff           @@
##             dev   #3274     +/-   ##
=======================================
+ Coverage     80%     81%     +1%     
=======================================
  Files        355     356      +1     
  Lines      27999   29623   +1624     
  Branches    3728    4321    +593     
=======================================
+ Hits       22327   23990   +1663     
+ Misses      4599    4570     -29     
+ Partials    1073    1063     -10

@304NotModified
Copy link
Member Author

looks too good to be true:

image

@304NotModified 304NotModified changed the title WIP: Make HttpNetworkSender mockable and add unit test Make HttpNetworkSender mockable and add unit test, introduce NSubsitute Apr 4, 2019
@304NotModified 304NotModified changed the title Make HttpNetworkSender mockable and add unit test, introduce NSubsitute Make HttpNetworkSender mockable, add unit test, introduce NSubsitute Apr 4, 2019
@304NotModified 304NotModified mentioned this pull request Apr 4, 2019
Merged
@304NotModified 304NotModified merged commit 45de9c5 into dev Apr 4, 2019
@304NotModified 304NotModified deleted the HttpNetworkSender-coverage branch April 4, 2019 23:35
@304NotModified 304NotModified added this to the 4.6.3 milestone Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
unit-tests
Projects
None yet
Milestone
4.6.3
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@304NotModified