Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null and recursive tests for ValueFormatter #3640

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

aerotog
Copy link
Contributor

@aerotog aerotog commented Oct 21, 2019

Helps with #3181. Includes some typo fixes in the same file.

I'm slightly concerned that the serialization result for the primitive 'null' is different for each CaptureType. Please verify the asserted values are expected for each CaptureType:

        [InlineData(CaptureType.Normal, "NULL")]
        [InlineData(CaptureType.Serialize, "null")]
        [InlineData(CaptureType.Stringify, "\"\"")]

@welcome
Copy link

welcome bot commented Oct 21, 2019

Thanks for opening this pull request!
We will try to review this soon! Please note that pull requests with unit tests are earlier accepted 👼

@304NotModified
Copy link
Member

Thanks!

I think you found a bug! Have to think about it what's expected output.

@304NotModified
Copy link
Member

[InlineData(CaptureType.Normal, "NULL")]

This is expected (in the docs)

    [InlineData(CaptureType.Serialize, "null")]

Serializable should be parseable, so also expected.

    [InlineData(CaptureType.Stringify, "\"\"")]

Doubting about this. Maybe it's nice you could control "" or null, so maybe this is also OK

@304NotModified 304NotModified added this to the 5.0 (new) milestone Oct 25, 2019
@304NotModified 304NotModified merged commit 129df5d into NLog:dev Oct 25, 2019
@welcome
Copy link

welcome bot commented Oct 25, 2019

Hooray your first pull request is merged! Thanks for the contribution! Looking for more? 👼 Please check the up-for-grabs issues - thanks!
thanks!

@304NotModified
Copy link
Member

Merge this one anyway, thanks!!

@aerotog aerotog deleted the feature/test-coverage branch October 25, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants