NLogLogger - Reduce allocation by not boxing EventId when CaptureEntireEventId = false

[snakefoot]

Resolves #318

[codecov-io]

Codecov Report

Merging #319 into master will increase coverage by 0.07%.
The diff coverage is 75%.

@@            Coverage Diff            @@
##           master    #319      +/-   ##
=========================================
+ Coverage   81.82%   81.9%   +0.07%     
=========================================
  Files          12      12              
  Lines        1150    1166      +16     
  Branches      195     198       +3     
=========================================
+ Hits          941     955      +14     
- Misses        140     141       +1     
- Partials       69      70       +1

Impacted Files	Coverage Δ
....Extensions.Logging/Logging/NLogProviderOptions.cs	100% <100%> (ø)	⬆️
src/NLog.Extensions.Logging/Logging/NLogLogger.cs	80.55% <72.22%> (+0.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7ee149...548570c. Read the comment docs.

[304NotModified]

this is a behavior change, isn't?

[snakefoot]

this is a behavior change, isn't?

Yes. Instead of having 3 EventId-properties to store Id + Name, then it now only uses 2.

I guess we could wait with this PR until NLog 5.0 has been released, then we can bump this to ver. 2.0

[304NotModified]

Good plan!

[304NotModified]

(WIP) for 2.0 release

[304NotModified]

👍

[codecov-commenter]

Codecov Report

Merging #319 into master will decrease coverage by 0.31%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
- Coverage   82.22%   81.90%   -0.32%     
==========================================
  Files          14       12       -2     
  Lines        1198     1166      -32     
  Branches      200      198       -2     
==========================================
- Hits          985      955      -30     
  Misses        141      141              
+ Partials       72       70       -2     

Impacted Files	Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs	80.55% <72.22%> (+0.05%)	⬆️
....Extensions.Logging/Logging/NLogProviderOptions.cs	100.00% <100.00%> (ø)
...og.Extensions.Logging/Logging/NLogLoggerFactory.cs	84.61% <0.00%> (-3.62%)	⬇️
...tensions.Logging/Extensions/ConfigureExtensions.cs	54.71% <0.00%> (-1.65%)	⬇️
...ensions.Logging/Config/NLogLoggingConfiguration.cs	91.98% <0.00%> (-0.37%)	⬇️
...xtensions.Logging/Config/SetupBuilderExtensions.cs
...Logging/Config/SetupExtensionsBuilderExtensions.cs
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs	97.18% <0.00%> (+1.94%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06574d4...b565946. Read the comment docs.

[codecov-io]

Codecov Report

Merging #319 (d4c23c0) into master (6defbc2) will increase coverage by 0.06%.
The diff coverage is 73.68%.

@@            Coverage Diff             @@
##           master     #319      +/-   ##
==========================================
+ Coverage   81.41%   81.48%   +0.06%     
==========================================
  Files          14       14              
  Lines        1227     1242      +15     
  Branches      204      207       +3     
==========================================
+ Hits          999     1012      +13     
- Misses        154      155       +1     
- Partials       74       75       +1     

Impacted Files	Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs	80.75% <72.22%> (+0.25%)	⬆️
....Extensions.Logging/Logging/NLogProviderOptions.cs	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6defbc2...d4c23c0. Read the comment docs.