Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogProviderOptions with support for CaptureEventId.EventId + EventName #554

Merged
merged 1 commit into from Dec 20, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Nov 16, 2021

Now captures EventId (integer) + EventName (string). Replacing EventId_Id and EventId_name. Resolves #553

Introduced option CaptureEventId and when assigned to Legacy then it will use old style.

Follow up to #319 and #538

@snakefoot snakefoot added this to the 5.0 milestone Nov 16, 2021
@snakefoot snakefoot closed this Nov 16, 2021
@snakefoot snakefoot reopened this Nov 16, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #554 (7f1ad19) into master (5b14701) will decrease coverage by 0.00%.
The diff coverage is 62.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
- Coverage   79.41%   79.40%   -0.01%     
==========================================
  Files          18       18              
  Lines        1516     1525       +9     
  Branches      254      257       +3     
==========================================
+ Hits         1204     1211       +7     
- Misses        187      188       +1     
- Partials      125      126       +1     
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 82.13% <54.54%> (-0.14%) ⬇️
...ions.Logging/Layouts/MicrosoftConsoleJsonLayout.cs 61.95% <75.00%> (ø)
.../LayoutRenderers/MicrosoftConsoleLayoutRenderer.cs 73.01% <100.00%> (ø)
....Extensions.Logging/Logging/NLogProviderOptions.cs 94.44% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b14701...7f1ad19. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change from EventId_Id and EventId_Name to EventId + EventName ?
2 participants