Chore/release

[RobertMaciejewski]

@iusztin
Prepared the release of the new version.
Link to draft release
https://github.com/NEWROPE/scnnr-ruby/releases/tag/untagged-7d3931b6d1959ddcbed0
Major update caused by #36 (review)
I want to confirm changelog and version choice - if it looks good I'll release it and after that rerun CI (I think it fails because of version change).

Please check 🙏

[iusztin]

Thank you for preparing the release :)
I agree about the new version & the changelog.

But about the failing RSpec I discovered something unfortunate 😓
The actual error is:

WebMock::NetConnectNotAllowedError:
  Real HTTP connections are disabled. Unregistered request: ...

After removing Gemfile.lock, running bunde and rspec I could reproduce it on my local.

I think it means Webmock fails to match some request that we make to a mocked request.

When checking the Gemfile I noticed we use a very wide version constrait for Webmock: https://guides.rubygems.org/patterns/#pessimistic-version-constraint and suspected it could have failed because of some breaking minor version change: https://github.com/bblimke/webmock/blob/master/CHANGELOG.md

Then I tried fixing webmock to a more precise version like gem 'webmock', '~> 3.0.0' and installed the bundle and ran rspec again -> passed on my local.

-> Sorry, could you take a closer look at this again? (and choose an appropriate Webmock version if needed :))

[RobertMaciejewski]

@iusztin
I couldn't reproduce it locally 😄
Turns out the version that was not working was 3.9.0 (which you were installing locally), but they managed to fix it in the meantime (about 7h ago) in 3.9.1. So the issue no longer occurs. After restarting CI build it works!
https://github.com/bblimke/webmock/blob/master/CHANGELOG.md#391

[iusztin]

Ah, super unlucky - or lucky? lol.
Great find :) Thanks!

[iusztin]

Thank you, LGTM!