Connects to #106. Google Analytics tag update. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed bug in which wrong release version number is passed to Google Analytics data download tracking event
…site was launched
…rors cause problems while compiling and building the app ESLint errors didn't cause any issues prior to react-scripts v3.x. So the React team released this patch in response to that. Also upgraded the storybook dependencies to address the vulnerability issue in its peer dependency.
…using app build problem in react-scripts v4.x
…or CRA production build This workaround could be temporary and reverted in the future
|
@jimmyzhen Regarding step 5, can you please let me know what line are you referring to in the |
|
@ysyskim4 Thank you for reviewing this PR. I will share a screenshot to explain what I meant. |
cteng585
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
analytics.jswithgtag.jsreact-scriptsdependency to latest version to address issue in which ESLint errors prevent app from compiling indevelopmentenvironment, as well as a vulnerability issue associated with its peer dependencyimmerstorybookdependencies to address a vulnerability issue associated with its peer dependencyimmerTechnical Note
Use
nvmto setnode.jstov14.15.4Steps to test
git clonethe repo and runyarn installat the repo's root directory..envfile and addESLINT_NO_DEV_ERRORS=truein the file (for references, see https://github.com/facebook/create-react-app/blob/master/docusaurus/docs/advanced-configuration.md and Upgrade eslint-webpack-plugin to fix opt-out flag facebook/create-react-app#10590).yarn inspect-branch, and expect to see ESLint warnings in the console (both in Terminal and browser) while the app can be successfully compiled and run.yarn auditand expect to see0 vulnerabilities foundin the output message.*.jsxfiles (e.g.releaseEntry.jsx) and expect to see some lines of code underlined (red wavy lines) - an indication thateslintandprettierare hinting fixes.devproperty.Realtime > Content. Then try clicking through different pages on the local instance of the frontend app. Expect to see the pageviews being reported in real time in Google Analytics.Realtime > Events. On the homepage of the local instance of the frontend app, try clicking on the 2 links. Expect to see the events being reported in real time in Google Analytics.