Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Google Analytics tag to the latest tag #106

Closed
kilodalton opened this issue Dec 15, 2020 · 3 comments
Closed

Update Google Analytics tag to the latest tag #106

kilodalton opened this issue Dec 15, 2020 · 3 comments
Assignees
@jimmyzhen
Labels
maintenance Stay up-to-date on dependencies

Comments

@kilodalton
Copy link
Contributor

Update current Google Analytics tag (analytics.js) to the latest tag (gtag.js)

You can find the global site tag (gtag.js) in your Analytics account and implement it directly on your website. Find more information in our dynamic tagging guide. Note: if you already use Google Tag Manager no action is needed.
@jimmyzhen jimmyzhen self-assigned this Feb 9, 2021
@jimmyzhen jimmyzhen added the maintenance Stay up-to-date on dependencies label Mar 5, 2021
jimmyzhen added a commit that referenced this issue Apr 15, 2021
@jimmyzhen
Connects to #106. Google Analytics tag update. (#118)
7d2ab70 
* Removed analytics.js dependence and installed gtag.js dependency

* Updated Google Analytics implementation with gtag.js

* Updated Google Analytics implementation with gtag.js

* Updated Google Analytics implementation callback for tracking event

* Updated Google Analytics implementation callback for tracking event

Also fixed bug in which wrong release version number is passed to Google Analytics data download tracking event

* Fixed unit test due to dependency changes

* Removed no longer needed assets after standalone human meta-analysis site was launched

* Updated some outdated dependencies

* Upgraded react-scripts dependency to address issue in which ESLint errors cause problems while compiling and building the app

ESLint errors didn't cause any issues prior to react-scripts v3.x. So the React team released this patch in response to that.

Also upgraded the storybook dependencies to address the vulnerability issue in its peer dependency.

* Removed ESLint rule overrides that were added due to ESLint errors causing app build problem in react-scripts v4.x

* Set DISABLE_ESLINT_PLUGIN environment variable to disable eslinting for CRA production build

This workaround could be temporary and reverted in the future

* Revert previously attempt to set environment variable when running the build
@kilodalton
Copy link
Contributor Author

@jimmyzhen is this resolved now?

@jimmyzhen
Copy link
Contributor

Yes. The changes have been merged into the dev branch recently.

@kilodalton
Copy link
Contributor Author

resolved with PR #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmyzhen jimmyzhen

Labels
maintenance Stay up-to-date on dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kilodalton @jimmyzhen