Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix CocoaPods install on Linux #9545

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 6, 2024

Description

Fixes and enables CocoaPods installation on Linux. After this change, macOS is not required to update Podfile.lock.

  • Enable pod install step in yarn setup script on all platforms, not just macOS
    • Failing installation is still only treated as actual failure on macOS
  • Apply react-native patch that resolves installation error due to attempt at patching missing Xcode
  • Upstream PR: chore: Increase iOS script portability facebook/react-native#44417
  • Add developer Dockerfile which can be used locally to run routine development tasks like yarn setup.
    • Add CI job that builds docker image and tests it with metamask-mobile repo
      • In order for the new job to run, the newly used actions must be enabled in repository settings. Preview run

Related issues

Manual testing steps

  1. Follow steps in scripts/docker/README.md to build and run docker image
  2. In container from built image, run: yarn setup
  3. Inspect that local pod installation completes

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented May 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat requested a review from Cal-L May 6, 2024 08:42
@legobeat legobeat marked this pull request as ready for review May 6, 2024 09:03
@legobeat legobeat requested review from a team as code owners May 6, 2024 09:03
@legobeat
Copy link
Contributor Author

legobeat commented May 6, 2024

This is only been tested on amd64 so far. Would be great if someone on aarch64 (like Apple Silicon) could test it as well.

As the CI job is already setting up qemu, it should be straightforward to have the image built and tested on aarch64/arm64 in a follow-up.

@legobeat legobeat changed the title chore: Ensure CocoaPods install on Linux chore: Fix CocoaPods install on Linux May 6, 2024
Base automatically changed from chore/ensure-gemfile-versions to main May 7, 2024 21:29
@legobeat legobeat force-pushed the pod-install-linux branch 3 times, most recently from 41c22be to 2d68073 Compare May 9, 2024 01:53
@legobeat legobeat force-pushed the pod-install-linux branch 4 times, most recently from 1be75ce to 00e0295 Compare May 9, 2024 11:25
@legobeat legobeat force-pushed the pod-install-linux branch 7 times, most recently from 9b81111 to f10a01a Compare May 14, 2024 00:14
@legobeat legobeat force-pushed the pod-install-linux branch 6 times, most recently from 7cce501 to dee274b Compare May 20, 2024 11:45
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 20, 2024

This comment was marked as outdated.

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 20, 2024
@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 20, 2024
Copy link
Contributor

github-actions bot commented May 20, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d7bd392
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f0f996d7-48ea-4e21-be45-08aa26fff001

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 20, 2024
@legobeat legobeat force-pushed the pod-install-linux branch 2 times, most recently from f7acaf2 to 0904796 Compare May 22, 2024 08:14
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs dev review
Development

Successfully merging this pull request may close these issues.

None yet

1 participant