Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade react-redux to support react 18; bump redux packages #9618

Merged
merged 8 commits into from May 16, 2024

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 13, 2024

Description

Currently used React version 18 is not officially supported until react-redux v8. Also brings in updates for other redux packages, but holds off on breaking changes for @reduxjs/toolkit v2.

  • Upgrade react-redux from 4.1.1 to 4.2.1
    • 4.2.1 was already used transitively so this is effectively a dedupe
  • Replace unmaintained rn-fetch-blob with react-native-blob-util

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@legobeat legobeat added dependencies Pull requests that update a dependency file team-security labels May 13, 2024
Copy link

socket-security bot commented May 13, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/react-native-blob-util@0.19.9

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat force-pushed the deps-redux branch 3 times, most recently from d058ac9 to d573178 Compare May 14, 2024 02:08
@legobeat

This comment was marked as resolved.

@legobeat legobeat force-pushed the deps-redux branch 2 times, most recently from 8645eac to 61422cd Compare May 14, 2024 03:41
@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat legobeat added the Run Smoke E2E Triggers smoke e2e on Bitrise label May 14, 2024
Copy link
Contributor

github-actions bot commented May 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 61422cd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3d818236-2de3-488b-a910-2e2083e09307

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@legobeat legobeat force-pushed the deps-redux branch 4 times, most recently from 4795b5a to 25f55d7 Compare May 14, 2024 07:25
@legobeat legobeat marked this pull request as ready for review May 14, 2024 07:25
@legobeat legobeat requested review from a team as code owners May 14, 2024 07:25
@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 14, 2024
Copy link
Contributor

github-actions bot commented May 14, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 25f55d7
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/2243ccd5-0901-474e-ab34-5b242c0d4bda

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 46.42%. Comparing base (220d717) to head (25f55d7).
Report is 18 commits behind head on main.

Files Patch % Lines
app/core/Snaps/location/npm.ts 0.00% 4 Missing ⚠️
app/core/Snaps/location/fetch.ts 0.00% 2 Missing ⚠️
app/util/browser/downloadFile.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9618      +/-   ##
==========================================
+ Coverage   46.27%   46.42%   +0.14%     
==========================================
  Files        1336     1340       +4     
  Lines       32582    32574       -8     
  Branches     3445     3483      +38     
==========================================
+ Hits        15076    15121      +45     
+ Misses      16594    16520      -74     
- Partials      912      933      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ios/Podfile.lock Outdated Show resolved Hide resolved
@legobeat legobeat removed the Run Smoke E2E Triggers smoke e2e on Bitrise label May 14, 2024
leotm
leotm previously approved these changes May 15, 2024
Copy link
Contributor

@leotm leotm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@leotm leotm added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 15, 2024
Copy link
Contributor

github-actions bot commented May 15, 2024

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 09ec49b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a402fc41-266b-4e7d-ad39-a2ccb7e289db

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Currenlty used React version 18 is not officially supported until react-redux v8.
Also brings in updates for other redux packages, but holds off on
breaking changes for @reduxjs/toolkit v2.
The latter is a maintained fork of abandoned former.

Holding on 0.18 to dedupliate on already used version from
redux-perists-filesystem-storage.

robwalkerco/redux-persist-filesystem-storage#68
- chore: dedupe react-native-blob-util thru resolutions
@legobeat
Copy link
Contributor Author

Resolved conflict in package.json on main rebase - no other changes.

Copy link

sonarcloud bot commented May 16, 2024

@legobeat legobeat added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels May 16, 2024
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: c39099b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9bcf37af-acbe-43b7-8d27-b97bc18a7ba8

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Copy link
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat merged commit 68167cd into main May 16, 2024
34 of 35 checks passed
@legobeat legobeat deleted the deps-redux branch May 16, 2024 22:58
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
@metamaskbot metamaskbot added the release-7.24.0 Issue or pull request that will be included in release 7.24.0 label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file release-7.24.0 Issue or pull request that will be included in release 7.24.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-security
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants