New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unity IL2CPP and New CodeGenerator #591
Conversation
IL2CPP test can run on CI.
|
and Added |
{ | ||
source.Add(file); | ||
} | ||
// TODO:resolve NuGet reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For our use case this is a blocker, but I understand that it isn't trivial to implement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I should support it but it will be a later.
Old mpc has many issues so must move to this model in v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly reviewed the common MessagePack code. I didn't spend much time on the MPC-specific stuff. Looks good.
src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Resolvers/StaticCompositeResolver.cs
Show resolved
Hide resolved
src/MessagePack.UnityClient/Assets/Scripts/MessagePack/Resolvers/StaticCompositeResolver.cs
Show resolved
Hide resolved
Also fix some issues the newer version of the analyzers found.
thanks. |
…ntation to StaticCompositeResolver, Fix UnityPackage exporeter, Fix compile error on Unity.
commented and add some fixes, it works in my local. |
The CI is failing with several errors that were warnings in VS' error list including these two:
The first one is because of #595 which ensures we don't accidentally forget The second one is because of #596 which requires that all public API changes to the Both of these warnings have code fix providers to make fixing all of them very easy: |
About #568, includes fix #559, #560, #562, #564
I've added new code generator
MessagePack.Generator
andMessagePack.MSBuild.Tasks
.MessagePack.UniversalCodeGenerator
is deperecated.MessagePack.Generator
can be dotnet core global tools so require to add nuget push script to ci.MessagePack.MSBuild.Tasks
is similar, so also require to add nuget push script to ci.New generator is port from #396.