Remove Nerdbank.Streams dependency #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replace the sync call with a true async implementation.
This fixes the remainder of the build breaks.
AArnott
approved these changes
Oct 21, 2019
|
The one downside to this change that I can see is that it makes |
AArnott
added a commit
to AArnott/MessagePack-CSharp
that referenced
this pull request
Nov 2, 2019
This spreads the intent of MessagePack-CSharp#592 to the source-distribution of MessagePack.
AArnott
added a commit
to AArnott/MessagePack-CSharp
that referenced
this pull request
Nov 6, 2019
This dependency was removed by MessagePack-CSharp#592
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only depends
Sequence<T>but if depend it, adds many other dependency.Working in #591 , I've encounted many annoying issues related to many managed dlls on Unity(and IL2CPP).
If removed
Nerdbank.Streams, we can removeMicrosoft.VisualStudio.Validation,Microsoft.VisualStudio.Threading,System.IO.Pipelines, too.It will solve #566.
Copy and paste code is not a shame things.
For example, HTTP/2 HPack Encoder is copy and pasted share between Kestrel and HttpClient.
Piplined SslStream(SslDuplexPipe) is copy and pasted share between Kestrel and Orleans.
Compared to them, it is just one file.