.NET 8 Update(7): Throw Exception Helper functions #1733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
requested changes
Jan 12, 2024
| @@ -11,10 +11,14 @@ internal static class ExpressionUtility | |||
| { | |||
| private static MethodInfo GetMethodInfoCore(LambdaExpression expression) | |||
| { | |||
| #if NET6_0_OR_GREATER | |||
| ArgumentNullException.ThrowIfNull(expression, nameof(expression)); | |||
There was a problem hiding this comment.
I don't want a bunch of #if statements for something so trivially addressible in another way. Just create an internal static helper class that has the if and throw check inside it, and use that in all the places you've changed here so we can do without the #if/#else blocks.
|
I keep my hands off this PR until #1734 will be completed since ThrowHelper.cs's appropriate path is unclear. |
pCYSl5EDgo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggressive Inlining is suppressed in function which has
throwstatement.Such a
ArgumentNullException.ThrowIfNullfunction helps inlining.