Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 8 #1725

Open
8 of 14 tasks
pCYSl5EDgo opened this issue Jan 10, 2024 · 4 comments
Open
8 of 14 tasks

Update to .NET 8 #1725

pCYSl5EDgo opened this issue Jan 10, 2024 · 4 comments

Comments

@pCYSl5EDgo
Copy link
Contributor

pCYSl5EDgo commented Jan 10, 2024

I've started making series of Pull Requests for .NET 8 update.

@pCYSl5EDgo
Copy link
Contributor Author

pCYSl5EDgo commented Jan 10, 2024

How to update the problematic package Microsoft.CodeAnalysis.Analyzers to version 3.3.4?
MessagePack.SourceGenerator/Transforms/*.tt and their generated .cs files have many errors in the v3.3.4.

There are some options to solve this.

  • Suppress RS1035 in .editorconfig file. <- Easiest
  • Hand rewrite T4 generated code unless T4 team solves the problem. <- Not Good
  • Write netstandard2.0 compatible InterpolatedStringHandler and rewrite the formatters. <- Better but extra work needs

@AArnott
Copy link
Collaborator

AArnott commented Jan 10, 2024

I'll have to take a look at this RS1035 issue. FWIW though, I already have a netstandard2.0 compatible interpolated string handler that we could perhaps copy from.

@pCYSl5EDgo
Copy link
Contributor Author

Oh! I am glad to hear that. After .NET 8 update, I'll try to make another PR for RS1035 issue unless T4 resolves.

@AArnott
Copy link
Collaborator

AArnott commented Jan 10, 2024

I think we should just disable RS1035. At least for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants