Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of kwargs passed to Requests #343

Merged
merged 1 commit into from Jan 4, 2021
Merged

Improve handling of kwargs passed to Requests #343

merged 1 commit into from Jan 4, 2021

Commits on Nov 2, 2020

  1. Improve handling of kwargs passed to Requests 

    We pass the form data to requests via `data` for POST methods, and
via `params` for GET methods. Therefore, we should be initializing
our data with the kwargs `data` or `params` respectively (whereas
previously we were initializing with `data` only).

Also added tests to check that we raise an exception when the kwargs
include a parameter that duplicates one of the args that we manually
set (i.e. `url` or `method`).
    @hemberger
    hemberger committed Nov 2, 2020
    Configuration menu
    Copy the full SHA
    d143124 View commit details
    Browse the repository at this point in the history