Improve handling of kwargs passed to Requests #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We pass the form data to requests via `data` for POST methods, and via `params` for GET methods. Therefore, we should be initializing our data with the kwargs `data` or `params` respectively (whereas previously we were initializing with `data` only). Also added tests to check that we raise an exception when the kwargs include a parameter that duplicates one of the args that we manually set (i.e. `url` or `method`).
ism
pushed a commit
to ism/MechanicalSoup
that referenced
this pull request
Mar 4, 2021
We pass the form data to requests via `data` for POST methods, and via `params` for GET methods. Therefore, we should be initializing our data with the kwargs `data` or `params` respectively (whereas previously we were initializing with `data` only). Also added tests to check that we raise an exception when the kwargs include a parameter that duplicates one of the args that we manually set (i.e. `url` or `method`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pass the form data to requests via
datafor POST methods, andvia
paramsfor GET methods. Therefore, we should be initializingour data with the kwargs
dataorparamsrespectively (whereaspreviously we were initializing with
dataonly).Also added tests to check that we raise an exception when the kwargs
include a parameter that duplicates one of the args that we manually
set (i.e.
urlormethod).