Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test_link_arg_* tests #261

Merged
merged 1 commit into from
Jan 18, 2019
Merged

Improve test_link_arg_* tests #261

merged 1 commit into from
Jan 18, 2019

Commits on Jan 17, 2019

  1. Improve test_link_arg_* tests 

    The `test_link_arg_regex` test was accidentally passing. By adding
another link to the test html, we can see that it was selecting the
first link instead of the link that matched the supplied regex.
This new version of the test fails, but it will be fixed by MechanicalSoup#256.

Also added a case for no arguments and reduced code duplication
by changing it to a parameterized test.
    @hemberger
    hemberger committed Jan 17, 2019
    Configuration menu
    Copy the full SHA
    2e00517 View commit details
    Browse the repository at this point in the history