Improve test_link_arg_* tests
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even if it doesn't happen for a long period of time, I prefer to avoid temporary breakage. This makes history bisectable and IMHO more readable. You can mark the test as known failure with |
The `test_link_arg_regex` test was accidentally passing. By adding another link to the test html, we can see that it was selecting the first link instead of the link that matched the supplied regex. This new version of the test fails, but it will be fixed by MechanicalSoup#256. Also added a case for no arguments and reduced code duplication by changing it to a parameterized test.
hemberger
force-pushed
the
fix-link-tests
branch
from
485f10f
to
2e00517
Compare
|
Aha, I had forgotten about |
tiboroche
pushed a commit
to tiboroche/MechanicalSoup
that referenced
this pull request
Mar 1, 2019
If you called the function with url_regex='/something' and not the link argument, it would set the url_regex to None, and thus the result would be impredictable. This is tested by the test added by MechanicalSoup#261
tiboroche
pushed a commit
to tiboroche/MechanicalSoup
that referenced
this pull request
Mar 1, 2019
If you called the function with url_regex='/something' and not the link argument, it would set the url_regex to None, and thus the result would be impredictable. This is tested by the test added by MechanicalSoup#261
moy
pushed a commit
that referenced
this pull request
Mar 1, 2019
If you called the function with url_regex='/something' and not the link argument, it would set the url_regex to None, and thus the result would be impredictable. This is tested by the test added by #261
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test_link_arg_regextest was accidentally passing. By addinganother link to the test html, we can see that it was selecting the
first link instead of the link that matched the supplied regex.
This new version of the test fails, but it will be fixed by #256.
Also added a case for no arguments and reduced code duplication
by changing it to a parameterized test.
I'm not sure what way would be best to merge this in, since it should
come before #256 (to demonstrate the existing failure), but we probably
don't want the master branch to be failing for an extended period of time.
Any thoughts?