Add support for shouldContainLineWithString and shouldNotContainLineWithString assertions #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusAmshove
requested changes
Oct 24, 2021
jvm/src/test/kotlin/org/amshove/kluent/tests/assertions/file/FileTestHelper.kt
Show resolved
Hide resolved
javatarz
approved these changes
Oct 27, 2021
|
Adding requsted changes on documentation and removal of dated comment. |
javatarz
approved these changes
Oct 27, 2021
MarkusAmshove
approved these changes
Oct 28, 2021
|
Thank you for the contribution :-) I'll see if the other two PRs get merged soon and build a release from that :) |
|
Thank you for accepting and a quick response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request add support for asserting that a File contains a line with required string as well as an assertion that a File does not contain a line with a specific string
This is a PR for Issue #192
Checklist
AUTHORSfile, if it wasn't already present.