Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent formatting #207

Merged
merged 3 commits into from Oct 30, 2021

Conversation

javatarz
Copy link
Contributor

@javatarz javatarz commented Oct 27, 2021

Description

Addresses all aspects of #206 except the pipeline changes for failing build due to formatting issues.

Will re-run these stages if the 2 current PRs get accepted soon or else I can send both @AarthiT for #205 and @priyaaank for #204 resolving merge conflicts on their branches.

Checklist

  • I've added my name to the AUTHORS file, if it wasn't already present.

@javatarz
Copy link
Contributor Author

Might I request a "hacktoberfest-accepted" tag on this? This will help be my 4th PR for hacktoberfest (while we are blocked on #205.

I'm also ok with us merging this PR since that file will have very minor conflicts which I can help resolve.

This follows IntelliJ's formatting style for imports
The next commit will add an editorconfig. The diff for the editor config introduction is not readable because imports are not consistently formatted.

Thus, this commit allows the next commit's diff to be readable.
Some files had CRLF endings and have been converted to LF
All changes in this commit have been caused purely by because of the addition of the `.editorconfig` file
Never thought formatting files would break tests, but they do when the line numbers change 😞
@MarkusAmshove MarkusAmshove merged commit 19830f9 into MarkusAmshove:master Oct 30, 2021
@javatarz
Copy link
Contributor Author

Thanks for merging @MarkusAmshove! Could you consider adding the "hacktoberfest" tag to the project? This should help participants such as myself reach our target of 4 accepted PRs in October 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants